Closed Bug 1622240 Opened 4 years ago Closed 4 years ago

Dark Theme - warning_text from Forget history menu - hard to read

Categories

(Firefox :: Toolbars and Customization, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 76
Tracking Status
firefox-esr68 --- wontfix
firefox74 --- wontfix
firefox75 --- wontfix
firefox76 --- verified

People

(Reporter: cfogel, Assigned: jaws)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image warnD.png

Affected versions

  • 74.0, 75.0b3, 76.0a1 (2020-03-12);

Affected platforms

  • Windows 10, macOS 10.13, Ubuntu 16.04;

Steps to reproduce

  1. Launch Firefox, click on the 3line/Hambourger menu button;
  2. Click on the Customize button;
  3. Change to Dark Theme and Drag the Forget button on the bar(anywhere to be visible);
  4. Exit the customize mode and click on the Forget button;

Expected result

  • text in the menu is readable;

Actual result

  • warning dark-red text on grey background is hard to read;

Regression range

  • most likely not a regression, but will check asap;

Additional notes

  • attached screenshot with the issue.
Component: Themes → Toolbars and Customization
Product: Toolkit → Firefox

1451947 looks like the most likely candidate.
@Ntim, can confirm when available.

Has Regression Range: --- → yes
Has STR: --- → yes
Flags: needinfo?(ntim.bugs)
Regressed by: 1451947

Sounds like we can go with a similar fix as bug 1530632.

Flags: needinfo?(ntim.bugs)
See Also: → 1530632
Priority: -- → P1
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46b402b1fab2
Brighten the warning text in the Forget panel so it works with both light and dark backgrounds. r=ntim
See Also: → 1623678
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76

Verified with 76.0a1 (2020-03-22), while an improvment is noticed it's still hard to the eyes.
Any chance this color can be changed to an even lighter one, or even white for dark theme?

  • or bold/shadow.
Flags: needinfo?(jaws)

(In reply to Cristian Fogel, QA [:cfogel] from comment #7)

Verified with 76.0a1 (2020-03-22), while an improvment is noticed it's still hard to the eyes.
Any chance this color can be changed to an even lighter one, or even white for dark theme?

  • or bold/shadow.

I filed bug 1623678 for this.

Flags: needinfo?(jaws)

Awesome, will start tracking that bug then.
Thank you!

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.