Closed Bug 1621598 Opened 4 years ago Closed 4 years ago

[macOS] - Console border-radius not applied for Reverse search history search-box

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(firefox-esr68 unaffected, firefox74 wontfix, firefox75 verified, firefox76 verified)

VERIFIED FIXED
Firefox 76
Tracking Status
firefox-esr68 --- unaffected
firefox74 --- wontfix
firefox75 --- verified
firefox76 --- verified

People

(Reporter: cfogel, Assigned: mail, Mentored)

References

Details

(Keywords: good-first-bug, regression)

Attachments

(2 files)

Affected versions

  • 76.0a1(2020-03-10), 75.0b1, 74.0;

Affected platforms

  • macOS 10.13.6;

Steps to reproduce

  1. Launch Firefox, enable DevTools, select the Console tab;
  2. Enable the history reverse search (F9 / CMD+R on mac);
  3. Click inside the bottom search-box;

Expected result

  • border-radius effect applied to the border making it appear rounded;

Actual result

  • border appears cut off at the edge;

Regression range

  • First bad: 882200a11bcf4629de8c589f954c73bd02300645 (2020-02-07)
  • Last good: b372743705c9c955e3f5cc08a1aa4cf09b6a0c2d (2020-02-06)
  • Pushlog: URL
  • prior to this the border had the sharp edges all around;

Additional notes

  • attached screenshot with the issue;
  • both light/dark themes are affected.
Has Regression Range: --- → yes
Has STR: --- → yes
Mentor: nchevobbe
Keywords: good-first-bug
Priority: -- → P3

Hey Nicolas!

I have a solution for this bug. Would you be able to assign it to me?

Flags: needinfo?(nchevobbe)

I assigned it to you Adam :)

Assignee: nobody → mail
Status: NEW → ASSIGNED
Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5fa2fe0e4ee
Add a border radius on Reverse Search Input for Mac OS platform r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76

Is this something you wanted to nominate for Beta uplift ahead of next week's RC?

Flags: needinfo?(mail)

Sure Ryan that would be cool!

Flags: needinfo?(mail)

Nicolas, maybe you can help shepherd that request?

Flags: needinfo?(nchevobbe)

Comment on attachment 9135056 [details]
Bug 1621598 - Add a border radius on Reverse Search Input for Mac OS platform

Beta/Release Uplift Approval Request

  • User impact if declined: border of the reverse search input in the console does not look good on OSX
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): css only, and devtools only, change
  • String changes made/needed:
Flags: needinfo?(nchevobbe)
Attachment #9135056 - Flags: approval-mozilla-beta?

(In reply to Ryan VanderMeulen [:RyanVM] from comment #8)

Nicolas, maybe you can help shepherd that request?

sure :)

Comment on attachment 9135056 [details]
Bug 1621598 - Add a border radius on Reverse Search Input for Mac OS platform

seems low enough risk, approved for 75.0b9

Attachment #9135056 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Verified with 76.0a1 (2020-03-26) and 75.0b10.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.