[macOS] - Console border-radius not applied for Reverse search history search-box
Categories
(DevTools :: Console, defect, P3)
Tracking
(firefox-esr68 unaffected, firefox74 wontfix, firefox75 verified, firefox76 verified)
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox74 | --- | wontfix |
firefox75 | --- | verified |
firefox76 | --- | verified |
People
(Reporter: cfogel, Assigned: mail, Mentored)
References
Details
(Keywords: good-first-bug, regression)
Attachments
(2 files)
48.83 KB,
image/png
|
Details | |
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
Affected versions
- 76.0a1(2020-03-10), 75.0b1, 74.0;
Affected platforms
- macOS 10.13.6;
Steps to reproduce
- Launch Firefox, enable DevTools, select the Console tab;
- Enable the history reverse search (F9 / CMD+R on mac);
- Click inside the bottom search-box;
Expected result
- border-radius effect applied to the border making it appear rounded;
Actual result
- border appears cut off at the edge;
Regression range
- First bad: 882200a11bcf4629de8c589f954c73bd02300645 (2020-02-07)
- Last good: b372743705c9c955e3f5cc08a1aa4cf09b6a0c2d (2020-02-06)
- Pushlog: URL
- prior to this the border had the sharp edges all around;
Additional notes
- attached screenshot with the issue;
- both light/dark themes are affected.
Reporter | ||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Hey Nicolas!
I have a solution for this bug. Would you be able to assign it to me?
Comment 2•4 years ago
|
||
I assigned it to you Adam :)
Assignee | ||
Comment 3•4 years ago
|
||
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5fa2fe0e4ee Add a border radius on Reverse Search Input for Mac OS platform r=nchevobbe
Comment 5•4 years ago
|
||
bugherder |
Comment 6•4 years ago
|
||
Is this something you wanted to nominate for Beta uplift ahead of next week's RC?
Comment 8•4 years ago
|
||
Nicolas, maybe you can help shepherd that request?
Comment 9•4 years ago
|
||
Comment on attachment 9135056 [details]
Bug 1621598 - Add a border radius on Reverse Search Input for Mac OS platform
Beta/Release Uplift Approval Request
- User impact if declined: border of the reverse search input in the console does not look good on OSX
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): css only, and devtools only, change
- String changes made/needed:
Comment 10•4 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #8)
Nicolas, maybe you can help shepherd that request?
sure :)
Comment 11•4 years ago
|
||
Comment on attachment 9135056 [details]
Bug 1621598 - Add a border radius on Reverse Search Input for Mac OS platform
seems low enough risk, approved for 75.0b9
Comment 12•4 years ago
|
||
bugherder uplift |
Updated•4 years ago
|
Updated•4 years ago
|
Reporter | ||
Comment 13•4 years ago
|
||
Verified with 76.0a1 (2020-03-26) and 75.0b10.
Description
•