Closed Bug 1621553 Opened 4 years ago Closed 4 years ago

Console - autocomplete remains stuck in position when swapping between Inline-Multiline mode

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(firefox74 wontfix, firefox75 wontfix, firefox76 verified)

VERIFIED FIXED
Firefox 76
Tracking Status
firefox74 --- wontfix
firefox75 --- wontfix
firefox76 --- verified

People

(Reporter: cfogel, Assigned: samarsault, Mentored)

Details

Attachments

(2 files)

Attached image ebm.gif

Affected versions

  • 76.0a1 (2020-03-10), 74.0, 75.0b1;

Affected platforms

  • Windows 10, macOS 10.15, Ubuntu 18.04;

Steps to reproduce

  1. Launch Firefox, enable DevTools, select the Console tab;
  2. Start typing in any expression;
  3. Once the autocomplete is displayed press CTRL+B to swap to multiline editor mode;

Expected result

  • autocomplete menu is displayed near the input / no longer displayed since another command was issued;

Actual result

  • menu remains in the initial position;

Regression range

  • not a regression;

Additional notes

  • attached recording with the issue;
  • another scenario would be to have some expressions written, if the Foxy Info-panel is closed, same results;
  • marking as minor since it's not a common-use scenario.

The fix should happen in devtools/client/webconsole/components/Input/JSTerm.js#557-567
In this if, we detect if we are going into editor mode, or back to inline mode.

In such case we should close the popup.

Mentor: nchevobbe
Priority: -- → P3

Can I work on this?

(In reply to Samarjeet from comment #2)

Can I work on this?

sure, it's now yours :)

Assignee: nobody → thelehhman
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/38cdc01220e8
Fix floating autocomplete on editor mode switch r=nchevobbe
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76

Verified with 76.0a1 (2020-03-30) , menu no longer displayed after switch.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.