Console - Selected input not cleared if selecting the preview or another expression
Categories
(DevTools :: Console, defect, P2)
Tracking
(firefox-esr68 disabled, firefox-esr78 wontfix, firefox73 disabled, firefox74 disabled, firefox75 wontfix, firefox76 wontfix, firefox77 wontfix, firefox78 wontfix, firefox79 verified)
People
(Reporter: cfogel, Assigned: nchevobbe)
Details
(Keywords: regression)
Attachments
(1 file)
Affected versions
- 75.0a1 (2020-03-05), 74.0, 68.6.0esr, 73.0.1;
Affected platforms
- Windows 10, macOS 10.15, Ubuntu 18.04
Steps to reproduce
- devtools.webconsole.input.eagerEvaluation set on true;
- Launch Firefox, enable DevTools, select the Console tab;
- Paste the following expression in the console input: 1+1
- Double click to select the preview(instant evaluation)
Expected result
- 1st selection is cleared;
Actual result
- selection from the initial item is not cleared;
Regression range
- First bad: build_date: 2018-07-30
- Last good: build_date: 2018-07-29
- Pushlog: URL;
Additional notes
- attached screenshot/recording with the issue;
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
Assignee | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
||
Comment 1•4 years ago
|
||
(set earlier releases to disabled because AIUI devtools.webconsole.input.eagerEvaluation is new)
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
CodeMirror does not have an option to automatically remove
the selection when the editor is blurred, which means there
can be a kind-of weird visual glitch when there was a selection
and the user does another selection.
This patch listen for the blur event on the editor, and if there
was a selection, removes it.
The blur event need to be piped down from the sourceeditor.
A test is added to ensure this works as expected.
|
||
Updated•4 years ago
|
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/68a40d1979df Reset editor selection when console input is blurred. r=Honza.
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
|
||
Comment 5•4 years ago
|
||
Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.
|
||
Updated•4 years ago
|
|
|
||
Comment 6•4 years ago
|
||
The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
For more information, please visit auto_nag documentation.
|
|
Assignee | |
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
Reporter | |
Comment 7•4 years ago
|
||
Verified with 79.0b2 on macOS 10.15, Windows 10, Ubuntu 18
Description
•