Closed Bug 1620240 Opened 4 years ago Closed 4 years ago

Console - Expression suggestion disappear after pressing Enter until moving the mouse

Categories

(DevTools :: Console, defect, P2)

defect

Tracking

(firefox-esr68 wontfix, firefox73 wontfix, firefox74 wontfix, firefox75 wontfix, firefox76 verified)

VERIFIED FIXED
Firefox 76
Tracking Status
firefox-esr68 --- wontfix
firefox73 --- wontfix
firefox74 --- wontfix
firefox75 --- wontfix
firefox76 --- verified

People

(Reporter: cfogel, Assigned: nchevobbe)

Details

Attachments

(2 files)

Attached image sugestionNHover.gif

Affected versions

  • 75.0a1 (2020-03-04), 68.6.0esr, 73.0.1, 74.0;

Affected platforms

  • Windows 10;

Steps to reproduce

  • devtools.webconsole.input.eagerEvaluation set on true;
  1. Launch Firefox, enable DevTools, select the Console tab;
  2. In the console type: console.
  3. Click away, then click back;
  4. Continue to type, not finishing the word: profile
  5. Hover the mouse over the unfinished word(suggestion for completion is displayed after ~2 seconds);
  6. Press the Enter key without moving the mouse

Expected result

  • suggestion is no longer displayed;

Actual result

  • suggestion lingers until moving the mouse cursor away;

Regression range

  • not a regression, appeared on the ~60(between beta 3 -13) branch when the changes to the console input location were implemented;
  • prior to these, there was no suggestion to complete the input as you type it;

Additional notes

  • attached recording with the issue;
  • with macOS(10.13), Ubuntu (19.04), this issue is not reproducible.

I guess this is also an issue with the tooltip still being displayed while the the underlying DOME element is gone.
Let's ask the graphic team if they're aware of such issue

Component: Console → Graphics
Product: DevTools → Core

Brendan, is this something that the DOM team could look into?

Component: Graphics → DOM: Core & HTML
Flags: needinfo?(bdahl)

It seems kind of odd for the tooltip to come up at all when hovering over the "file" autocomplete result. Could we instead just disable the tooltip for it?

There's still probably an underlying issue with the tooltip showing when the element is removed, but I'm not sure that needs to be fixed for this.

Flags: needinfo?(bdahl) → needinfo?(nchevobbe)

You're right I think
We're using it in order to be able to append the title in a pseudo after element, but this could be a regular data attribute I think

Flags: needinfo?(nchevobbe)
Component: DOM: Core & HTML → Console
Product: Core → DevTools
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: -- → P2

There are no good reason this should be set on the title element.
Furthermore the title attribute triggers displaying a tooltip, which
might look odd and cause issue.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55ba6b244beb
Use a data attribute for displaying the completion text instead of the title in the editor. r=gl.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76

Verified the fix with Nightly 76.0a1 (2020-03-15) on Windows 10 x64.
Updating the flag status -> Verified.

Thanks for the input!

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.