Closed Bug 1620178 Opened 4 years ago Closed 4 years ago

About pages not updating colors on theme change

Categories

(Firefox :: Theme, enhancement)

Unspecified
All
enhancement
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1529323

People

(Reporter: cfogel, Unassigned)

Details

Attachments

(1 file)

Attached image downloads theme.gif

Affected versions

  • 75.0a1 (2020-03-04), 74.0;

Affected platforms

  • Windows 10, macOS 10.15, Ubuntu 19.04;

Steps to reproduce

  1. Launch Firefox;
  2. Access about:downloads
  3. Click on the HambourgerMenu button;
  4. Click on the Customize button;
  5. Click on the Themes button;
  6. Click on the one opposing your current theme ( Light vs Dark );
  7. Restart the browser and access about:downloads

Expected result

  • theme is updated;

Actual result

  • theme inside the page remains the same, not updated after changing it;

Regression range

  • will provide one asap;

Additional notes

  • attached recording with the issue(Windows 10 - dark theme;
  • issue noticed with Windows10/Ubuntu19 - dark theme, macOS 10.15 - light theme.
Has Regression Range: --- → no
Has STR: --- → yes

This behavior targets all the about pages, not a regression, issue visible since bug 1545029 implementation.

Type: defect → enhancement
Has Regression Range: no → ---
Summary: about:downloads page not updating colors on theme change → About pages not updating colors on theme change

:ntim, can you help clarify what is going on here? I'm a bit confused because bug 1545029 was nightly-only, and I don't understand why (per steps in comment #0) this wouldn't be fixed after a restart (though the gif seems not to restart the browser the way the STR suggest).

Flags: needinfo?(ntim.bugs)

(In reply to :Gijs (he/him) from comment #2)

:ntim, can you help clarify what is going on here? I'm a bit confused because bug 1545029 was nightly-only, and I don't understand why (per steps in comment #0) this wouldn't be fixed after a restart (though the gif seems not to restart the browser the way the STR suggest).

This has been enabled by default everywhere since bug 1565051.

This is quite unfortunate, but in-content dark mode follows the system theme as opposed to the browser theme. This works fine for the Default theme case, because the default theme follows the system theme, but I agree it's confusing for other themes. There's bug 1529323 filed about this.

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(ntim.bugs)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.