Open Bug 1619591 Opened 4 years ago Updated 1 year ago

Download manager animation is displayed improperly on Windows and Ubuntu

Categories

(Firefox :: Downloads Panel, defect, P3)

Desktop
All
defect

Tracking

()

Tracking Status
firefox73 --- wontfix
firefox74 --- wontfix
firefox75 --- wontfix
firefox76 --- fix-optional

People

(Reporter: vlucaci, Unassigned)

References

Details

(Keywords: blocked-ux, polish, regression)

Attachments

(1 file)

Attached image Download Animation.gif

Affected versions

  • 75.0a1(ID:20200302212732)
  • 74.0(ID:20200302184608)

Affected platforms

  • Windows 10 x64
  • Ubuntu 18.04x64
  • Windows 10x64 ARM
  • Windows 7x64

Steps to reproduce

  1. Launch Firefox and navigate to http://testsafebrowsing.appspot.com/
  2. Go to Desktop Download Warnings
  3. Right click the "link" in order to trigger the context menu.
  4. Select "Save link as" option and save it locally.

Expected result

  • Once the download starts, the animation is displayed only once, without any issues.

Actual result

  • Once the download animation ends, the begging of the animation is displayed once again.

Notes

  • This issue does not occur in 73.0.1.
  • The animation issue occurs slightly different for Ubuntu. The animation starts with an irregularly big, pixelated download icon that is displayed out of its desginated area.

Regression range

  • Will return with a regression ASAP

Hello,

I have returned with a regression range as well as a video attachment for the Ubuntu platform.
Video attachment: https://drive.google.com/open?id=1W78haSIiKnp457NeHKFc2c_0tF63_NYm

First Bad: 2020-02-07
Last Good:2020-02-06
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ee653474267a8b3660c9d70f659b5f655d3ed586&tochange=882200a11bcf4629de8c589f954c73bd02300645
Potential regressor: 1612104

Has Regression Range: --- → yes

While bug 1612104 made it more visible, I don't think it's the right culprit, likely the animation timing just needs some polish.

From the video it doesn't look that bad though, I'd just expect the grey arrow to move to the button before the button arrow bumps. I suspect this is also due to the fact these downloads are really short, does the problem happen downloading something that takes more than a couple seconds?

These animations were implemented so much time ago, and have been broken for a bit, it may be worth for UX to have a review and see if they should be changed.

Keywords: blocked-ux, polish
Priority: -- → P3

Downloading larger files(10mb+) does render a lesser unpolished version of the animation so it is true that this is mostly obvious for downloads that last only a few seconds.

UX should take a look and take this polish into consideration(especially for the Ubuntu platform) as there, the problem reproduces with larger downloaded files and the grey arrow is displayed out of its designated area.

I don't think the animations should need to change. Its possible we are getting the start notification after the finish notification which would have the effect captured in that video. Bear in mind that we start downloading a file in the background before the user clicks download, so its not uncommon for a smaller download to be already finished. That said, we could do a better job of handling this case if that's actually what's going on.

There is some logging you can enable by setting the pref browser.download.loglevel to Debug.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.