Closed
Bug 1619228
Opened 4 years ago
Closed 4 years ago
The user is able to add a separator to the Address Bar
Categories
(Firefox :: Toolbars and Customization, defect, P2)
Firefox
Toolbars and Customization
Tracking
()
People
(Reporter: csasca, Assigned: adw)
Details
(Keywords: regression)
Attachments
(2 files)
Affected versions
- Firefox 68.5.0esr
- Firefox 73.0.1
- Firefox 74.0b9
- Firefox 75.0a1
Affected platforms
- Windows 10 & 7
- Ubuntu 18.04
- macOS 10.15 & 10.13
Steps to reproduce
- Launch Firefox
- Open a page, for example Wikipedia to trigger the extra controls from the Address Bar
- Access the dropdown from the three dots and spam right click on the separator until the popup with Add to address bar is shown
Expected result
- The separator can't be added to Address Bar
Actual result
- The separator can be added to the Address Bar
Regression range
- I will see for a regression range.
Additional notes
- The issue can be seen in the attachment.
- There are only some points on the separator which will trigger the Add to address bar option.
Reporter | ||
Updated•4 years ago
|
Has Regression Range: --- → no
Has STR: --- → yes
Comment 1•4 years ago
|
||
It's not so easy to trigger, but this can effectively cause long term brokeness or unexpected bugs.
Drew, do you have any time to look into this?
Flags: needinfo?(adw)
Priority: -- → P2
Comment 2•4 years ago
|
||
Regression range
- First bad: 7dddbd85047c6dc73ddbe1e423cd643a217845b3
- Last good: 5ca5691372cb432ec1fa4693ca608a30858226de
- Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4f4487cc2d30d988742109868dcf21c4113f12f5&tochange=7dddbd85047c6dc73ddbe1e423cd643a217845b3
Reporter | ||
Updated•4 years ago
|
Has Regression Range: no → yes
Keywords: regressionwindow-wanted → regression
Assignee | ||
Comment 3•4 years ago
|
||
I'll take a look. I'd like to keep page action bugs in Toolbars and Customization, so I'll also move this there.
Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 75.2 - Feb 24 - Mar 8
Points: --- → 2
Component: Address Bar → Toolbars and Customization
Flags: needinfo?(adw)
Assignee | ||
Comment 4•4 years ago
|
||
Separators are technically actions, so we should ignore them when deciding whether to open the context menu.
Updated•4 years ago
|
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/92606f7d0241 Prevent the context menu from opening on separators in the page action panel. r=Gijs
Comment 6•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
Updated•4 years ago
|
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•