Closed Bug 1619228 Opened 4 years ago Closed 4 years ago

The user is able to add a separator to the Address Bar

Categories

(Firefox :: Toolbars and Customization, defect, P2)

defect
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 75
Iteration:
75.2 - Feb 24 - Mar 8
Tracking Status
firefox-esr68 --- wontfix
firefox73 --- wontfix
firefox74 --- wontfix
firefox75 --- fixed

People

(Reporter: csasca, Assigned: adw)

Details

(Keywords: regression)

Attachments

(2 files)

Affected versions

  • Firefox 68.5.0esr
  • Firefox 73.0.1
  • Firefox 74.0b9
  • Firefox 75.0a1

Affected platforms

  • Windows 10 & 7
  • Ubuntu 18.04
  • macOS 10.15 & 10.13

Steps to reproduce

  1. Launch Firefox
  2. Open a page, for example Wikipedia to trigger the extra controls from the Address Bar
  3. Access the dropdown from the three dots and spam right click on the separator until the popup with Add to address bar is shown

Expected result

  • The separator can't be added to Address Bar

Actual result

  • The separator can be added to the Address Bar

Regression range

  • I will see for a regression range.

Additional notes

  • The issue can be seen in the attachment.
  • There are only some points on the separator which will trigger the Add to address bar option.
Has Regression Range: --- → no
Has STR: --- → yes

It's not so easy to trigger, but this can effectively cause long term brokeness or unexpected bugs.
Drew, do you have any time to look into this?

Flags: needinfo?(adw)
Priority: -- → P2

Regression range

Has Regression Range: no → yes

I'll take a look. I'd like to keep page action bugs in Toolbars and Customization, so I'll also move this there.

Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 75.2 - Feb 24 - Mar 8
Points: --- → 2
Component: Address Bar → Toolbars and Customization
Flags: needinfo?(adw)

Separators are technically actions, so we should ignore them when deciding whether to open the context menu.

Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92606f7d0241
Prevent the context menu from opening on separators in the page action panel. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
You need to log in before you can comment on or make changes to this bug.