Closed Bug 1618525 Opened 4 years ago Closed 4 years ago

about:logins - remove hover effect for [Sort by] login-sort dropdown button if it is disabled

Categories

(Firefox :: about:logins, defect)

defect
Not set
minor

Tracking

()

VERIFIED FIXED
Firefox 75
Tracking Status
firefox-esr68 --- unaffected
firefox73 --- wontfix
firefox74 --- wontfix
firefox75 --- verified

People

(Reporter: cfogel, Assigned: itiel_yn8)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image hoverAbout.gif

Affected versions

  • 73.0.1, 74.0b8, 75.0a1 (2020-02-27);

Affected platforms

  • Windows 10, macOS 10.15, Ubuntu 18.04;

Steps to reproduce

  1. Launch Firefox, access about:logins
  2. Remove all the logins if any;
  3. Hover over the Name (A-Z) button;

Expected result

  • UX-wise - nothing should happen, button is disabled;

Actual result

  • hover effect triggered on both light/dark theme;

Regression range

  • Pushlog: URL
  • Introduced with: 1584162;

Additional notes

  • attached recording with the issue;

Bugbug thinks this bug is a defect, but please change it back in case of error.

Type: enhancement → defect
Flags: needinfo?(itiel_yn8)
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Flags: needinfo?(itiel_yn8)
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/e1ed4b83448f
Don't apply the hover effect on the login-sort dropdown button if there are no logins r=MattN
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
Has Regression Range: --- → yes
Has STR: --- → yes

Verified the issue with Firefox Nightly 75.0a1 (2020-03-05) on Windows 10 x64, Ubuntu 18.04 and mac OS 10.15, it is no longer reproducible.

Awesome, thank you for your input!
Updating the bug-status as well.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.