Closed
Bug 1617920
Opened 4 years ago
Closed 4 years ago
[macOS] Improve visibility of the separators on bookmarks toolbar when in dark theme
Categories
(Firefox :: Theme, defect, P3)
Tracking
()
People
(Reporter: asoncutean, Assigned: Gijs)
References
Details
(Keywords: regression)
Attachments
(1 file)
10.08 KB,
image/png
|
Details |
Affected versions
- 75.0a1 (2020-02-25)
- 74.0b7
- 73.0
Affected platforms
- macOS 10.15
- macOS 10.13
Steps to reproduce
- Enable the Bookmark Toolbars
- Add several New Separators (right-click on the toolbar bookmarks)
Expected result
- The separators are clear, the contrast is strong
Actual result
- The separators are barely visible
Regression range
- The first one, reflects the state until the contrast was good, but not necessary when it started to be bad, the bad build shows no separator at all
- First bad: f6c3a0a19d82db25750d8badccd5cf37e79d028e (2018-04-11)
- Last good: da809ecceaf3a8ada0aa2d7115822d39d0439654 (2018-04-12)
- Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f6c3a0a19d82db25750d8badccd5cf37e79d028e&tochange=da809ecceaf3a8ada0aa2d7115822d39d0439654
- The second regression range solved the separator being invisible, but the contrast of the separator became an issue that could be now observed visually
- First bad: 47e81ea1ef10189ef210867934bf36e14cf223dc (2018-05-23)
- Last good: ff8505d177b9fcba44b040ccd9b6bb709e238e84 (2018-05-24)
- Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=47e81ea1ef10189ef210867934bf36e14cf223dc&tochange=ff8505d177b9fcba44b040ccd9b6bb709e238e84
Additional notes
- On Windows/Ubuntu the separators are visible.
Reporter | ||
Updated•4 years ago
|
Has Regression Range: --- → yes
Has STR: --- → yes
Comment 1•4 years ago
|
||
old regression, wontfix for 73/74
Updated•4 years ago
|
Updated•4 years ago
|
Keywords: regression
Updated•4 years ago
|
Keywords: regression
Updated•4 years ago
|
Keywords: regression
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
I fixed this in bug 1665442. \o/
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Depends on: 1631554
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Assignee | ||
Updated•4 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Flags: qe-verify+
Comment 4•3 years ago
|
||
Verified with 85.0a1 (2020-11-19), 84.0b2 on macOS 10.15.
You need to log in
before you can comment on or make changes to this bug.
Description
•