Closed Bug 1617623 Opened 4 years ago Closed 4 years ago

Popular image formats are not detected in Save as Type field

Categories

(Firefox :: File Handling, defect, P3)

Desktop
Windows 10
defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox73 --- wontfix
firefox74 --- wontfix
firefox75 --- wontfix
firefox78 --- verified

People

(Reporter: vlucaci, Assigned: Gijs)

References

Details

(Whiteboard: [fixed by bug 1366645])

Attachments

(2 files)

Attached image Empty Type field.PNG

Affected versions

  • 73.0.1 (ID:20200217142647)
    *74.0b7(ID:20200221211950)

Affected platforms

  • Windows 10x64

Steps to reproduce

  1. Launch FF.
  2. Go to http://cdn2.collective-evolution.com/assets/uploads/2009/09/url.jpeg
  3. Right click the image , and in the context menu select "Save image as"

Expected result

  • A new OS window is opened, with 2 fields in the lower side. The "Save as type" drop-down automatically detects the format of the image and the File name automatically fills with the default name

Actual result

  • A new OS windows is opened with 2 fields in the lower side. The "Save as type" drop-down does not automatically detect the image format and the field remains empty.

Regression range

  • Will return with regression ASAP

Additional notes

  • This issue occurs only with image formats such as .jpg , .png , .gif , etc.

Andrew do you know how this type gets set?

Flags: needinfo?(aosmond)
Has Regression Range: --- → no
Has STR: --- → yes
Priority: -- → P3

(In reply to Vlad Lucaci, QA (:vlucaci) from comment #0)

Affected versions

  • 73.0.1 (ID:20200217142647)
    *74.0b7(ID:20200221211950)

Is esr68 not affected?

  • This issue occurs only with image formats such as .jpg , .png , .gif , etc.

Can you provide other examples? And, does this really occur on all websites with these images? I noticed that this particular site does not in fact send a Content-Type header for the image, which may be related - though on my win10 machine, my regular 74 beta profile does offer me a value for the filetype in the dropdown in the dialog - I expect this is to do with what mime data we can provide through either the OS mimetype database and/or the local handler service (handlers.json datafile in the profile). bug 1366645 may be related, see also bug 1602220.

Flags: needinfo?(vlad.lucaci)

This is something that was also on my radar as well for a while.

There seem to be some additional steps up, since opening & trying to save the same image once revealed the issue; but at a later date, the same image was being picked up properly (format wise).
A few days ago, the issue reproduced(at home) again with the image from this link but trying today again it seems to be working fine.

(In reply to Cristian Fogel, QA [:cfogel] from comment #3)

This is something that was also on my radar as well for a while.

There seem to be some additional steps up, since opening & trying to save the same image once revealed the issue; but at a later date, the same image was being picked up properly (format wise).
A few days ago, the issue reproduced(at home) again with the image from this link but trying today again it seems to be working fine.

Possibly to do with the details in bug 1602220, ie what extensions / mimetypes are in the profile's handlers.json ? Also possible that the server used to not send a content-type header and has been fixed...

Running on 75.0a1 - 20200229214828 on the Firefox at home (updated to 20200301094802 as I was double checking with a fresh profile).
Issue still reproduces.
Checking around, can confirm that once this issue is up: .png, .jpg, .gif, save snapshot of youtube have the same fate.

Posting the handlers.json contents:
{"defaultHandlersVersion":{"en-US":4},"mimeTypes":{"application/pdf":{"action":3,"extensions":["pdf"]},"image/jpeg":{"action":0,"ask":true,"extensions":["jpg"]},"application/zip":{"action":0,"ask":true,"extensions":["zip"]},"image/png":{"action":0,"ask":true,"extensions":["png"],"handlers":[{"name":"Photoshop.exe","path":"C:\Program Files\Adobe\Adobe Photoshop CC 2018\Photoshop.exe"}]},"audio/mpeg3":{"action":0,"ask":true,"extensions":["mp3"]},"video/mp4":{"action":0,"ask":true,"extensions":["mp4"]},"application/x-ole-storage":{"action":0,"ask":true,"extensions":["msi"]},"video/webm":{"action":0,"ask":true,"extensions":["webm"]},"application/rar":{"action":0,"ask":true,"extensions":["rar"]},"application/rtf":{"action":4,"ask":true,"extensions":["rtf"]}},"schemes":{"ircs":{"action":2,"ask":true,"handlers":[null,{"name":"Mibbit","uriTemplate":"https://www.mibbit.com/?url=%s"}]},"mailto":{"action":4,"handlers":[null,{"name":"Yahoo! Mail","uriTemplate":"https://compose.mail.yahoo.com/?To=%s"},{"name":"Gmail","uriTemplate":"https://mail.google.com/mail/?extsrc=mailto&url=%s"}]},"irc":{"action":2,"ask":true,"handlers":[null,{"name":"Mibbit","uriTemplate":"https://www.mibbit.com/?url=%s"}]},"webcal":{"action":4,"ask":true},"steam":{"action":4,"ask":true},"magnet":{"action":4,"ask":true},"com.unity3d.kharma":{"action":4,"ask":true}}}

(In reply to Cristian Fogel, QA [:cfogel] from comment #5)

Running on 75.0a1 - 20200229214828 on the Firefox at home (updated to 20200301094802 as I was double checking with a fresh profile).
Issue still reproduces.
Checking around, can confirm that once this issue is up: .png, .jpg, .gif, save snapshot of youtube have the same fate.

Please provide links to where you're testing.

Flags: needinfo?(cristian.fogel)
Attached image extensions.gif

Attaching a recording as well with the scenario reported.

Sure:

Any other format that might be relevant with this?

Flags: needinfo?(cristian.fogel)

Hello,

I tried to narrow down the repro steps using 68.6.0esr (20200305175243) with the images provided by :cfogel in comment 8.

As stated in comment 3 , the behavior seems to require additional steps as I was only able to reproduce the issue once out of 10 attempts.

I will further investigate this and will return once I have narrowed down the exact behavior.

Flags: needinfo?(vlad.lucaci)

(In reply to Cristian Fogel, QA [:cfogel] from comment #8)

Sure:

Any other format that might be relevant with this?

I don't know. None of these reproduce for me on Windows. Can you reproduce on a clean profile, with any of them? If not, can you reproduce once you copy the handlers.json file over?

Also, can you attach an about:support for the affected profile?

Flags: needinfo?(cristian.fogel)

Hello,

I have managed to reproduce the issue with a clean profile with all the attachments provided in the comment above on a Windows 10x64 machine with 74.0(ID:20200309095159)
The issue persisted even after refreshing/restarting the browser , and even after saving one of the images.

I have attached 2 documents with the about:support of the affected profile:
about:support Raw Data: https://drive.google.com/open?id=1wwPWvHf9XGOHZ4UHmgsJbrWKCBI0bb1Q
about:support text Data: https://drive.google.com/open?id=1XgshBb8K2fDIoTu78L6TZKMIa6V4KNwa

Flags: needinfo?(cristian.fogel)

(In reply to Vlad Lucaci, QA (:vlucaci) from comment #11)

Hello,

I have managed to reproduce the issue with a clean profile with all the attachments provided in the comment above on a Windows 10x64 machine with 74.0(ID:20200309095159)

Am I right in deducing you cannot reproduce this on every windows machine? Any difference in other installed software you can spot between the machines where this does and doesn't happen? Or difference in OS locales or something like that?

Flags: needinfo?(vlad.lucaci)

I can reproduce on any v of Windows machine(v1903, v1909) in the end but there are (still) some unknown variables to us that cause this and I am still working on it to isolate them.

It can happen to reproduce the behavior on a clean and/or fresh install, and after a while, on the same machine/OS, it is as if the issue was never present and everything works as expected.

Flags: needinfo?(vlad.lucaci)

Seems related to bug 1638480 perhaps. It feels like we should probably favour own our list if we didn't get something sufficiently useful from the OS (e.g. no preferred extensions for a MIME type).

Component: ImageLib → File Handling
Flags: needinfo?(aosmond)
Product: Core → Firefox
Depends on: 1366645

I think bug 1366645 fixed this. Can you check on the machines where you noticed this issue previously? :-)

Flags: needinfo?(vlad.lucaci)

Hello,

I have tried to reproduce this issue on the latest 80.0a1 (2020-07-08), 79.0b5 and 78.0.2 with Windows 10x64 and did not manage to reproduce it anymore. I have been following this issue for a while, ever since the NI was created with no avail. If I will ever encounter it again, I will re-open a ticket concerning this.

Flags: needinfo?(vlad.lucaci)

Thanks!

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by bug 1366645]
See Also: → 1656837
You need to log in before you can comment on or make changes to this bug.