Closed Bug 1616725 Opened 4 years ago Closed 4 years ago

enable "dom.audioworklet.enabled" on beta and release

Categories

(Core :: Web Audio, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox76 --- fixed
firefox77 --- fixed

People

(Reporter: karlt, Assigned: karlt)

References

(Depends on 2 open bugs)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

"dom.worklet.enabled" too

Depends on: 1619486
Depends on: 1619607
Blocks: 1473176
Depends on: 1625372
Depends on: 1627169
Depends on: 1628842

The dependencies of this bug are factors in the decision to enable for Beta, but are not hard blockers.
I'm preparing an intent to ship with the aim of enabling this on Beta.

Summary: allow "dom.audioworklet.enabled" to ride to beta and release → enable "dom.audioworklet.enabled" on beta and release
Assignee: nobody → karlt
Status: NEW → ASSIGNED
Depends on: 1630149

Comment on attachment 9140687 [details]
Bug 1616725 set dom.audioworklet.enabled and dom.worklet.enabled for Beta and Release

Beta/Release Uplift Approval Request

  • User impact if declined: Missing feature. e.g. bug 1626109.

I'm putting in this Beta uplift request before landing on mozilla-central due to time constraints. The change enables a feature which is currently enabled on Nightly.

  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Medium
  • Why is the change risky/not risky? (and alternatives if risky): The risk is from shipping a reasonably large chunk of new code.
    Risk is limited by the pref changes only affecting the new feature.
  • String changes made/needed: None.
Attachment #9140687 - Flags: approval-mozilla-beta?

Do we need a follow-up bug for removing all the manual pref-setting from the various tests?

Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63a9800a7e4e
set dom.audioworklet.enabled and dom.worklet.enabled for Beta and Release r=baku,padenot

Comment on attachment 9140687 [details]
Bug 1616725 set dom.audioworklet.enabled and dom.worklet.enabled for Beta and Release

This has been enabled on Nightly for awhile now, has good web-platform-test coverage (which we've been testing on Beta already by manually flipping the pref), and has an intent to ship sent. Given the high webcompat need for this, approved for 76.0b5.

Attachment #9140687 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Blocks: 1630497

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)

Do we need a follow-up bug for removing all the manual pref-setting from the various tests?

Filed bug 1630497, thanks.

In addition to cleaning up the existing AudioWorklet reference content, I've submitted a BCD update to set up values for Firefox and have written a new guide to using AudioWorklet

Regressions: 1647750
Regressions: 1677888
Regressions: 1680410
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: