Closed Bug 1612798 Opened 4 years ago Closed 4 years ago

[macOS]Debugger - Pressing space key toggles Event listener section instead of updating state for LOG button

Categories

(DevTools :: Debugger, defect, P2)

Unspecified
macOS
defect

Tracking

(firefox72 wontfix, firefox73 wontfix, firefox74 wontfix)

RESOLVED WONTFIX
Tracking Status
firefox72 --- wontfix
firefox73 --- wontfix
firefox74 --- wontfix

People

(Reporter: cfogel, Unassigned)

References

Details

Affected versions

  • 72.0a1 (2019-11-05), 73.0b11, 74.0a1 (2020-02-02);

Affected platforms

  • macOS 10.15

Steps to reproduce

  1. Launch Firefox, enable DevTools; access the Debugger tab;
  2. @ the breakpoints the Event Listener Breakpoints;
  3. Click inside the Log Events checkbox;
  4. Press the SPACE key on the keyboard 2x times;

Expected result

  • checkbox is toggled on/off;

Actual result

  • section is collapsed/expanded;
  • the button_status toggle doesn't change the toggle(d) status;

Regression range

  • Pushlog URL;
  • First bad revision: 2019-09-18;
  • Last good revision: 2019-09-17;
  • most likely became visible with bug 1110276, according to the pushlog;

Additional notes

  • follow up for bug 1594382, while at first glimpse they might look the same, it's another issue since in this case the toggle button is not toggled (checked/unchecked);
  • recording with issue can be found here, per c#12 in bug 1594382

@Stepan, this is a follow up for bug 1594382 you've been working on. Do you have any tips why this doesn't work on MacOS?

Honza

Flags: needinfo?(obdelnik)

I don't think this problem is related just to the debugger because it seems that any checkbox behaves unexpectedly on MacOS in general.

Steps to reproduce:

  1. Go to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/checkbox
  2. Click on any checkbox
  3. Press spacebar

AR:
The checkbox loses focus and the page is scrolled down.

ER:
The checkbox toggles.

Works on Windows though. As shown c#12 in bug 1594382, after the space bar is pressed the checkbox loses focus and the whole section toggles, but it seems that is more 'core' issue on MacOS.

Flags: needinfo?(obdelnik) → needinfo?(odvarko)

Thanks for the analysis.
I can reproduce weird behavior with other checkboxes too.

after the space bar is pressed the checkbox loses focus and the whole section toggles, but it seems that is more 'core' issue on MacOS.

I am wondering whether we could fix the Accordion component somehow...

Honza

Flags: needinfo?(odvarko)

Maybe we should first move this to Core (DOM: UI Events & Focus Handling ?) and ask about this macos issue?

Seems like checkboxes are not properly capturing the space key event on macos. As comment 2 mentions, this can be reproduced on any page with a checkbox. If no other event handler captures the event, then pressing space will trigger a page scroll.

Neil, you worked some time ago on https://bugzilla.mozilla.org/show_bug.cgi?id=1180761, which seems similar. Do you know if the current behavior is a regression?

Edit: testing a bit more, the root cause of the issue seems to be that the checkbox doesn't gain focus when it is clicked.

Flags: needinfo?(enndeakin)
Has Regression Range: --- → yes
Has STR: --- → yes

Edit: testing a bit more, the root cause of the issue seems to be that the checkbox doesn't gain focus when it is clicked.

This is the correct behaviour on MacOS. Only textboxes and lists should receive focus when clicked.

Flags: needinfo?(enndeakin)

Thanks for the comment Neil!

Closing the report.

Honza

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.