Closed Bug 1609945 Opened 4 years ago Closed 1 year ago

[Ubuntu] Picture in Picture player is moved from original position when resizing

Categories

(Core :: Widget: Gtk, defect, P3)

Desktop
Linux
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox72 --- wontfix
firefox73 --- wontfix
firefox74 --- wontfix
firefox75 --- wontfix

People

(Reporter: atrif, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

Affected versions

  • 74.0a1 (20200117094453)
  • 73.0b6 (20200116232741)
  • 72.0.1 (20200107212822)

Affected platforms

  • Ubuntu 16.04 x64/x32

Steps to reproduce

  1. Open Firefox and load a random video from YouTube.
  2. Click the PiP button.
  3. Slowly resize the PiP player from the top left and stop when the video is being cut.

Expected result

  • No glitches presented when resizing the video.

Actual result

  • The video initial location is moved is resize stops in certain spots.

Regression Range

  • I will search for one ASAP if there is one.

Notes

Has Regression Range: --- → no
Has STR: --- → yes

Any idea what's happening here, Martin?

Blocks: videopip
Component: Video/Audio Controls → Widget: Gtk
Flags: needinfo?(stransky)
Product: Toolkit → Core

Looks like GDK_HINT_ASPECT is not effective here. It may be a Gtk bug on Ubuntu 16.
Alexandru, which Gtk3 version is used there?
Thanks.

Flags: needinfo?(stransky) → needinfo?(alexandru.trif)

Attaching here the console's output for both GTK 2 and 3:

apt-cache policy libgtk2.0-0 libgtk-3-0

libgtk2.0-0:
  Installed: 2.24.30-1ubuntu1.16.04.2
  Candidate: 2.24.30-1ubuntu1.16.04.2
  Version table:
 *** 2.24.30-1ubuntu1.16.04.2 500
        500 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages
        100 /var/lib/dpkg/status
     2.24.30-1ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu xenial/main amd64 Packages
libgtk-3-0:
  Installed: 3.18.9-1ubuntu3.3
  Candidate: 3.18.9-1ubuntu3.3
  Version table:
 *** 3.18.9-1ubuntu3.3 500
        500 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages
        100 /var/lib/dpkg/status
     3.18.9-1ubuntu3 500
        500 http://archive.ubuntu.com/ubuntu xenial/main amd64 Packages

If any information is needed please let me know! Thank you!

Flags: needinfo?(alexandru.trif)

Attaching the regression range. Also, worth mentioning that on the 'good" builds the player is not moved when resizing but white lines are presented narrowing the video a bit. I hope it helps.

Last good revision: 1dc1a755079a15e35cb234db511e52ab463b2f42
First bad revision: 1d189ae70326e415f8590e3aeee24885fb8418bc
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1dc1a755079a15e35cb234db511e52ab463b2f42&tochange=1d189ae70326e415f8590e3aeee24885fb8418bc
Possible regressor: bug 1580733.

Has Regression Range: no → yes

I think it's:

Martin Stransky — Bug 1580733 - Don't use dialog for PIP window on Linux, r=JSON_voorhees
Martin Stransky — Bug 1583737 - Implement nsWindow::LockAspectRatio() on Linux, r=jhorak

we changed window type from dialog to toplevel window and enabled the aspect ratio control by Gtk. I think Ubuntu 16 uses Unity, right?

Alexander, can you please post a screencast how the PIP window behaves in non-broken Firefox version?
What I see on the "bad" screencast may be visible CSD + ignored window aspect ratio.
Thanks.

Flags: needinfo?(alexandru.trif)

btw. can you try to run latest (broken) Firefox as on terminal:

MOZ_GTK_TITLEBAR_DECORATION=client firefox
MOZ_GTK_TITLEBAR_DECORATION=system firefox

and see if there's any difference?
Thanks.

Attached video pip_good_build.mp4

(In reply to Martin Stránský [:stransky] from comment #6)

Alexander, can you please post a screencast how the PIP window behaves in non-broken Firefox version?
What I see on the "bad" screencast may be visible CSD + ignored window aspect ratio.
Thanks.

Yes, ofc. Attached here the screencast.

Also for
MOZ_GTK_TITLEBAR_DECORATION=client firefox -> screenshot here - with this command I observed that PiP window is opened sometimes on random areas of the screen and different sizes.

MOZ_GTK_TITLEBAR_DECORATION=system firefox -> screenshot here

I hope I understand it right how to open Firefox with these commands. I ran Firefox with each command separately and the issue is reproducible with each of them. Or if there is another way on how to do this please let me know. Thank's!

Flags: needinfo?(alexandru.trif)

:stransky, could please you assign a priority for this bug?

Flags: needinfo?(stransky)

Looks like a GL issue to me. Alexandru, do you have any kind of GL acceleration enabled? WebRender or GL compositor?

Flags: needinfo?(alexandru.trif)

(In reply to Martin Stránský [:stransky] from comment #11)

Looks like a GL issue to me. Alexandru, do you have any kind of GL acceleration enabled? WebRender or GL compositor?

hmm... I can no longer reproduce the issue on Firefox 74.0b9. I looked for a fixed range and mozregression pointed out this one:
First good revision: a98ec6d23cb918db7e1b59952e75da1dae7eafe2
Last bad revision: 3bcada926ad7f223eda4c35dd04c21056ca5c75b
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3bcada926ad7f223eda4c35dd04c21056ca5c75b&tochange=a98ec6d23cb918db7e1b59952e75da1dae7eafe2
It seems that Bug 1600414 fixes the resizing issue.

But the player it's still moved from the initial position after selecting random videos on Youtube. So the STR used in 74.0b9 (20200227210932) on Ubuntu 16.04 are:

  1. Open Firefox with a clean profile and a random video from Youtube along with PiP player.
  2. Select other videos from youtube while the PiP player is opened.
    AR: The player is moved.
    The issue is reproducible if the videos have different heights: e.g load this, open PiP player, then go to another random one from the right side, and then click back to return to the initial one.
Flags: needinfo?(alexandru.trif)
Severity: normal → S3
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.