Closed
Bug 1609872
Opened 4 years ago
Closed 4 years ago
Make about:policies an HTML page
Categories
(Firefox :: Enterprise Policies, task, P5)
Firefox
Enterprise Policies
Tracking
()
VERIFIED
FIXED
Firefox 75
Tracking | Status | |
---|---|---|
firefox75 | --- | verified |
People
(Reporter: ntim, Assigned: emilghitta)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
Updated•4 years ago
|
Keywords: good-first-bug
Updated•4 years ago
|
Priority: -- → P5
Assignee | ||
Comment 1•4 years ago
|
||
Hi,
I'd like to give this a try (to get familiar with the code base and how to contribute to it).
Is there somebody currently working on this?
Thank you! :D
Reporter | ||
Comment 2•4 years ago
|
||
(In reply to Emil Ghitta, QA [:emilghitta] from comment #1)
Hi,
I'd like to give this a try (to get familiar with the code base and how to contribute to it).
Is there somebody currently working on this?
There isn't, please go for it :)
Steps to fix this bug:
- removing <?xml version="1.0" encoding="UTF-8"?> in browser/components/enterprisepolicies/content/aboutPolicies.xhtml
- In this same file, removing
xmlns="http://www.w3.org/1999/xhtml"
from the<html>
tag - (optional, but would be nice to do here too), removing the type attribute from this line: https://searchfox.org/mozilla-central/source/browser/components/enterprisepolicies/content/aboutPolicies.xhtml#13
- Changing
/>
to proper HTML closing tags fortitle
,script
,div
,tbody
,th
elements- for instance,
<title data-l10n-id="about-policies-title"/>
would become<title data-l10n-id="about-policies-title"></title>
- for instance,
- running
hg mv browser/components/enterprisepolicies/content/aboutPolicies.xhtml browser/components/enterprisepolicies/content/aboutPolicies.html
- In browser/components/about/AboutRedirector.cpp and browser/components/enterprisepolicies/jar.mn, aboutPolicies.xhtml needs to be replaced with aboutPolicies.html
Please let me or Mike know if you've got any questions :)
Assignee: nobody → emil.ghitta
Assignee | ||
Comment 3•4 years ago
|
||
Updated•4 years ago
|
Attachment #9131752 -
Attachment description: Bug 1609872 - Make about:policies an HTML page r?ntim → Bug 1609872 - Make about:policies an HTML page. r?ntim
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/03852000dace Make about:policies an HTML page. r=ntim
Comment 5•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
Comment 6•4 years ago
|
||
Hello,
Verified this issue on Windows 10x64, Ubuntu 18.04 and macOS 10.15 with 75.0a1 (20200309091841). No regressions have been introduced.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•