Closed Bug 1608425 Opened 4 years ago Closed 4 years ago

The picture-in-picture button is hidden beneath other buttons that are present on the page on twitch.tv

Categories

(Toolkit :: Video/Audio Controls, defect, P3)

Product:
Toolkit
Component:
Video/Audio Controls
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox73 --- wontfix
firefox74 --- verified
firefox75 --- verified

People

(Reporter: obotisan, Assigned: mconley)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

Screenshsfewfqot_1.png
69.69 KB, image/png
Details
Bug 1608425 - Adjust Picture-in-Picture toggle to be at 25% from the top for Twitch videos. r?denschub
47 bytes, text/x-phabricator-request
Details | Review
Attached image Screenshsfewfqot_1.png —

Affected versions

  • Firefox 73.0b1
  • Nightly 74.0a1

Affected platforms

  • Windows 10 x64
  • Windows 7 x86
  • Ubuntu 18.04 x64
  • macOS 10.13

Steps to reproduce

  1. Go to twitch.tv.
  2. Click on a video to watch it.
  3. Search for the PiP button.

Expected result

  • The button can be seen easily.

Actual result

  • The button is hidden behind the scrollbar and other buttons that are present on the page.

Regression range

  • I don't think this is a regression, I can reproduce the issue on builds from 2019-04-20.

Additional notes

  • It doesn't matter if you resize the window, the button is still hidden.
  • Please look at the attached image.
Blocks: videopip
Depends on: 1592286
Priority: -- → P3
Assignee: nobody → mconley
Status: NEW → ASSIGNED

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b25fed24cf8f
Adjust Picture-in-Picture toggle to be at 25% from the top for Twitch videos. r=denschub

:mconley, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mconley)

https://hg.mozilla.org/mozilla-central/rev/b25fed24cf8f

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox74: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
Flags: needinfo?(mconley)
Keywords: regression
Flags: qe-verify+

Issue is no longer reproducible i.e. the pip button is moved to 25% from the top of the video.

  • Additional note: on live streaming videos the pip button is not functional in case there is a semitransparent iframe.
Blocks: 1616289

I've managed to reproduce this issue on Firefox 74.0a1 (2020-01-10) using Windows 10x64 by following the STR from comment 0.
This issue is verified fixed on Firefox 74.0b6 and Firefox 75.0a1 (2020-02-21) on the following OSes: Windows 10x64, Windows 7x64, macOS 10.15 and Ubuntu 18.04x64.

Status: RESOLVED → VERIFIED
status-firefox74: fixed → verified
status-firefox75: --- → verified
Flags: qe-verify+
Regressions: 1623600
See Also: → 1655802
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: