[macOS] Disabled drag space label (ie when title bar is enabled) inside Customize page is barely visible with dark OS theme
Categories
(Firefox :: Toolbars and Customization, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox72 | --- | wontfix |
firefox73 | --- | verified |
firefox74 | --- | verified |
People
(Reporter: asoncutean, Assigned: Gijs)
Details
(Keywords: regression)
Attachments
(2 files)
9.15 KB,
image/png
|
Details | |
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
[Affected versions]:
- 72.0.1
- 73.0b2
- 74.0a1 (2020-01-07)
[Affected platforms]:
- macOS 10.14
- macOS 10.15
[Steps to reproduce]:
- Open the Customize page (Menu - Customize)
- Check the Title Bar options
[Expected result]:
- Drag Space options turns inactive, no visual issue can be observed
[Actual result]:
- Drag Space options turns inactive, but it is hardly visible
[Regression range]:
- I will provide one asap
[Additional notes]:
- Issue not reproducible with dark mode on Windows
Reporter | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Comment 2•4 years ago
|
||
Bugbug thinks this bug is a regression, but please revert this change in case of error.
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b102c4cb93af fix drag space label contrast in dark lwthemes, r=nhnt11
Comment 4•4 years ago
|
||
bugherder |
Comment 5•4 years ago
|
||
Please nominate this for Beta approval when you get a chance.
Assignee | ||
Comment 6•4 years ago
|
||
Comment on attachment 9119800 [details]
Bug 1608106 - fix drag space label contrast in dark lwthemes, r?nhnt11
Beta/Release Uplift Approval Request
- User impact if declined: Unreadable label
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Check the readability of the checkbox label from the summary of this bug in dark themes (cross-platform) and high contrast mode (on Windows).
- List of other uplifts needed: n/a
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Simple CSS fix.
- String changes made/needed: nope
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Reporter | ||
Comment 7•4 years ago
|
||
This issue is verified fixed with Fx 74.0a1 (2020-01-15) using dark mode/high contrast on macOS 10.15, Windows 10 x64 and Ubuntu 18.04 x64.
Comment 8•4 years ago
|
||
Comment on attachment 9119800 [details]
Bug 1608106 - fix drag space label contrast in dark lwthemes, r?nhnt11
Simple fix for a visual glitch. Approved for 73.0b6.
Comment 9•4 years ago
|
||
bugherder uplift |
Reporter | ||
Comment 10•4 years ago
•
|
||
(In reply to Anca Soncutean [:Anca], Desktop Release QA from comment #7)
This issue is verified fixed with Fx 74.0a1 (2020-01-15) using dark mode/high contrast on macOS 10.15, Windows 10 x64 and Ubuntu 18.04 x64.
I confirm the issue is verified fixed on Fx 73.0b6 as well across platforms.
Description
•