Closed Bug 1607465 Opened 4 years ago Closed 4 years ago

Pinned tabs are jumping out of their normal position while being dragged

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 74
Tracking Status
firefox-esr68 --- unaffected
firefox72 - wontfix
firefox73 + verified
firefox74 + verified

People

(Reporter: emilghitta, Assigned: ntim)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image pinnedtabs.gif

Affected versions

  • Firefox 72.0 (BuildId:20200103162918)
  • Firefox 73.0b1 (BuildId:20200106175743)
  • Firefox 74.0a1 (BuildId:20200107095722)

Affected platforms

  • Windows 10 64bit.
  • Windows 10 32bit.
  • Windows 7 32bit.
  • Ubuntu 18.04 64bit.
  • macOS 10.11

Steps to reproduce

  1. Launch Firefox.
  2. Open around 20 tabs.
  3. Pin several tabs.
  4. Drag a pinned tab in order to change its position.

Expected result

  • The pinned tab is successfully dragged and placed in a new position without any UI issues.

Actual result

  • It seems that during the drag event the pinned tab shifts downwards (outside of its normal position), overlapping the beneath buttons.

Regression Range

Notes

  • For further information regarding this issue please observe the attached screencast.
  • It seems that this issue is only reproducible if multiple tabs are opened ( until the tab navigation buttons ( "<" and ">" are displayed).
Has Regression Range: --- → yes
Has STR: --- → yes

Emilio mentioned that bug 1606130 fixes this. :)

Depends on: 1606130
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED

[Tracking Requested - why for this release]: user visible regression when dragging tabs

Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f1fc99ba989d
Fix position of pinned tabs when dragged. r=bgrins

Comment on attachment 9119168 [details]
Bug 1607465 - Fix position of pinned tabs when dragged. r=bgrins

Beta/Release Uplift Approval Request

  • User impact if declined: Wrong vertical alignment for pinned tabs when dragged
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See comment 0
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): self-contained CSS change
  • String changes made/needed: none
Attachment #9119168 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74

Not sure we need to track this for Fx72, but leaving this on the radar for a possible dot release ride-along given how trivial the patch is.

Comment on attachment 9119168 [details]
Bug 1607465 - Fix position of pinned tabs when dragged. r=bgrins

Trivial fix for a pretty obvious UI issue when dragging pinned tabs. Approved for 73.0b3.

Attachment #9119168 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

This issue is verified fixed using Firefox 74.0a1 (BuildId:20200108215606) and Firefox 73.0b3 (provided in comment 9) on Windows 10 64bit, macOS 10.13.6 and Ubuntu 18.04 64bit.

Leaving a ni on myself in case of a possible dot release.

Status: RESOLVED → VERIFIED
Flags: qe-verify+ → needinfo?(emil.ghitta)
Flags: needinfo?(emil.ghitta)
You need to log in before you can comment on or make changes to this bug.