Open Bug 1606431 Opened 4 years ago Updated 2 years ago

[Win] Add button (active state) is only partially highlighted when using Tab navigation inside New Bookmark panel

Categories

(Core :: Widget: Win32, defect, P3)

All
Windows
defect

Tracking

()

Tracking Status
firefox-esr68 --- wontfix
firefox71 --- wontfix
firefox72 --- wontfix
firefox73 --- fix-optional
firefox74 --- fix-optional

People

(Reporter: asoncutean, Unassigned)

References

(Regression)

Details

(Keywords: polish, regression)

Attachments

(1 file)

Attached image screenshot issue.png

[Affected versions]:

  • 72.0
  • 72.0b11
  • 73.0a1 (2019-12-30)

[Affected platforms]:

  • Windows 10
  • Windows 7

[Steps to reproduce]:

  1. Enable the Toolbar Bookmarks
  2. Right click on the Toolbar Bookmarks and select New Bookmark option
  3. Enter a web address inside the Location to activate the Add button
  4. Navigate the New Bookmarks fields using the Tab key

[Expected result]:

  • Once the selection reach the Name field the Add button is completely highlighted

[Actual result]:

  • Once the selection reach the Name field the Add button is only partially highlighted

[Regression range]:

  • Not a recent regression, reproducible on RC 71.0 as well: I will provide additional info asap

[Additional notes]:

  • MacOS 10.15 and Ubuntu 18.04 are not affected
  • I can see the same issue inside New folder panel

I can reproduce.
STR

  1. Right click on Bookmarks toolbar
  2. Choose New Folder
  3. Shift+Tab

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a9afb304dbb69dfab72128cf355f627f9af25828&tochange=54a7d6b486195d982aa5f4d6f1cff7ac2dd3f75c

Regressed by: 54a7d6b486195d982aa5f4d6f1cff7ac2dd3f75c Dão Gottwald — Bug 1334429 - Remove fallback styling from button.css. r=mak

Has Regression Range: --- → yes
Has STR: --- → yes
Component: Bookmarks & History → Themes
Product: Firefox → Toolkit
Regressed by: 1334429

This looks like a native theme invalidation issue...

(In reply to Alice0775 White from comment #1)

Regressed by: 54a7d6b486195d982aa5f4d6f1cff7ac2dd3f75c Dão Gottwald — Bug 1334429 - Remove fallback styling from button.css. r=mak

I guess changing -moz-border-left-colors took care of this even though those borders weren't rendered?

Component: Themes → Widget: Win32
Product: Toolkit → Core

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jmathies)

Tried to reproduce on win10. When focus got to the Cancel button, it stopped there and remained highlighted.

Flags: needinfo?(jmathies)
Keywords: polish
Priority: -- → P3
See Also: → 1652018
Severity: minor → S4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: