Closed Bug 1604170 Opened 4 years ago Closed 4 years ago

No icon for “Credit Cards” in “Sync Settings”

Categories

(Firefox :: Sync, defect, P3)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
Firefox 79
Tracking Status
firefox71 --- wontfix
firefox72 --- wontfix
firefox73 --- wontfix
firefox79 --- verified

People

(Reporter: atrif, Assigned: markh)

Details

(Whiteboard: [cc-autofill-mvp])

Attachments

(2 files)

Attached image sync_creditcards_noicon

Affected versions

  • 73.0a1 (20191216095052)
  • 72.0b7 (20191213132525)
  • 71.0 (20191202093317)

Affected platforms

  • Windows 10x64
  • Ubuntu 18.04
  • macOS 10.15

Preconditions

  • set extensions.formautofill.creditCards.available to true, extensions.formautofill.available to "on" and browser.search.region to "en-US" and restart browser
  • logged in to Sync

Steps to reproduce

  1. Open Firefox and click on Firefox Account-> Sync Settings (about:preferences#sync).
  2. Under the Syncing option click on the “Change” button.
  3. Observe the “Credit cards” option.

Expected result

  • Icon displayed in front of the “Credit cards” option like o the other ones.

Actual result

  • “Credit cards” option has no icon.

Regression Range

  • Reproducible with Firefox 71.0a1 (20191005214618). I will search for one ASAP.

Notes

  • Attached a screenshot with the issue.
Has Regression Range: --- → no
Has STR: --- → yes
Priority: -- → P3

Thanks, Alexandru! Since we aren't shipping credit card syncing on any build by default, there isn't an icon for it—this isn't really a regression, there just isn't an icon that we can use yet. 😄 We'll want to revisit this when we're ready to enable credit card syncing, but, until then, moving it to the backlog.

Has Regression Range: no → irrelevant

chrome://formautofill/content/icon-credit-card-generic.svg should work fine.

Assignee: nobody → markh
Status: NEW → ASSIGNED
Pushed by mhammond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/492f854a046c
add an icon for the credit-cards sync engine. r=MattN
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
Whiteboard: [cc-autofill-mvp]

Verified - Fixed in latest Nightly 79.0a1 (build id: 20200614215300) using Windows 10 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.