Closed Bug 1603397 Opened 4 years ago Closed 4 years ago

[Mac] Cancel button overlap the above message on Restart Firefox dropdown

Categories

(Firefox :: General, defect, P1)

72 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 73
Tracking Status
firefox-esr68 --- unaffected
firefox71 --- unaffected
firefox72 --- disabled
firefox73 --- verified

People

(Reporter: zstimi, Assigned: dholbert)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image issue.png

Affected versions

  • Firefox 72.0b5

Affected platforms

  • macOS 10.15

Steps to reproduce

  1. Launch Firefox.
  2. Access the "about:preferences#privacy" page.
  3. Select the "Never remember history" option from the History dropdown list.
  4. Observe the Restart Firefox dropdown.

Expected result

  • The Cancel button not overlap the above message.

Actual result

  • The Cancel button overlap the above message. Please see the attached screenshot.

Regression range
This is a recent regression.
GOOD : 2019.12.04 - 20191204215924
BAD: 2019.12.03 - 20191203215345
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3c08edf74d039af79f9daad8ff5b57ffb64fdab6&tochange=32f84899fc000d95337a25c14a27470d0c52e3ee

Additional notes

  • Issue only on macOS, Firefox beta 72.0b4, 72.0b5, on nightly 73.0a1 from 2019.12.04 this issue is fixed. BAD nightly is 2019.12.03.
Has Regression Range: --- → yes

Can you get a narrower regression window (ie an autoland one) please?

Flags: needinfo?(timea.zsoldos)

First good revision: 2d39de2be1ae9fa8063a19b459d8712fa90bc851
Last bad revision: dfa7714e0543412adf6ee9e065069f9fe5d1b025
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=dfa7714e0543412adf6ee9e065069f9fe5d1b025&tochange=2d39de2be1ae9fa8063a19b459d8712fa90bc851

Flags: needinfo?(timea.zsoldos)
Status: NEW → RESOLVED
Closed: 4 years ago
Depends on: 1593060
Keywords: regression
Priority: -- → P1
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
Assignee: nobody → dholbert

In fact, looking at the flags again, you found a fix window, but when did this regress on 72?

Flags: needinfo?(timea.zsoldos)

Builds from Fx 72.0b1 are affected.

Flags: needinfo?(timea.zsoldos)

Right, but what about nightly 72?

(In reply to Julien Cristau [:jcristau] from comment #5)

Right, but what about nightly 72?

Yeah, this. FWIW, I can't reproduce the bug at all, which makes it difficult to do this myself.

Flags: needinfo?(timea.zsoldos)

So in the image [A] it is shown the dialog before it got broken in a few steps.

  • First it was broken in Nightly 69.0a1 by bug 1544916 (based on regression range A to B)
  • Then it was broken in Nightly 72.0a1 by bug 1583925 (based on regression range B to C)
    Finally the image [D] shows the current Nightly 73.0a1 design which in my opinion got broken again based on other dialogues, for example Make Firefox default dialogue (I did not went to track what changed that but I can do that)

Regression ranges:

B to C (image B to image C)

12:12.04 INFO: Last good revision: cefb0e6f314aa176684e1fce4b71d649ca674c2d
12:12.04 INFO: First bad revision: 70b2e0edb9a100ab95af8d7713f99dbc8ebd1ca0
12:12.04 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cefb0e6f314aa176684e1fce4b71d649ca674c2d&tochange=70b2e0edb9a100ab95af8d7713f99dbc8ebd1ca0

A to B (image A to image B)

11:57.90 INFO: Last good revision: 5e7c2d9420574ed055721a9685ff0d048d15399c
11:57.90 INFO: First bad revision: 843c150636f81fb2f13196844206514f8a938bd9
11:57.90 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5e7c2d9420574ed055721a9685ff0d048d15399c&tochange=843c150636f81fb2f13196844206514f8a938bd9

Flags: needinfo?(timea.zsoldos)

Thanks. It does look kind of wide still. :ntim, anything we can do for 72 here, and/or do you know what's causing the dialog to be overly wide on current nightly?

Flags: needinfo?(ntim.bugs)
Regressed by: 1583925, 1544916

(In reply to :Gijs (he/him) from comment #8)

Thanks. It does look kind of wide still. :ntim, anything we can do for 72 here, and/or do you know what's causing the dialog to be overly wide on current nightly?

Bug 1602939 fixed a similar overlapping issue in Nightly caused by bug 1593060. I guess uplifting this could fix it.

As for the dialog looking too wide, I think this is due to the increased min-width in bug 1599996. It used to be 29em - Lmargin - Rmargin, now it's 29em sharp.

I don't have time to craft a patch and test it in time for Firefox 72 though.

Flags: needinfo?(ntim.bugs) → needinfo?(gijskruitbosch+bugs)

I think we can live with this on 72 at this point.

Flags: needinfo?(gijskruitbosch+bugs)
Flags: qe-verify+

I can confirm this issue is fixed, I verified using Firefox 73.0b4 on macOS 10.14.5.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.