Closed Bug 1600007 Opened 4 years ago Closed 4 years ago

The Enterprise Policies service is active but there are no policies enabled

Categories

(Firefox :: Enterprise Policies, defect, P3)

Desktop
Windows
defect

Tracking

()

VERIFIED FIXED
Firefox 73
Tracking Status
firefox-esr68 --- verified
firefox71 --- wontfix
firefox72 --- verified
firefox73 --- verified

People

(Reporter: vlucaci, Assigned: mkaply)

References

Details

Attachments

(1 file)

Affected versions

  • 72.0a1 (20191127215655)
  • 71.0b12 (20191121155457)

Affected platforms

  • Windows 10x64
  • Windows 7x64

Steps to reproduce

  1. Install Avast antivirus.
  2. Install FF.
  3. Uninstall Avast antivirus.
  4. Launch FF.
  5. Go to about:policies/about:troubleshooting/about:preferences.

Expected result

  • There should be no active policies, and the about:policies/about:troubleshooting/about:preferences should not display any information in that regard.

Actual result

  • About policies page is blank but no policy is displayed
  • About:troubleshooting displays the Enterprise policies section as Active.
  • About:preferences displays the : "browser is managed by organization" message.

This case was initially tested and verified in Bug 1560808 using AVAST antivirus. During the investigation performed in that bug we tried to reproduce the bug (on both beta and nightly Fx versions which contained the fix) but the faulty behavior seemed to be indeed fixed.

However during various tests and further investigation we manage to reproduce the faulty behavior from Bug 1560808. But now, it doesn't have a 100% reproducibility rate.

Currently, this issues, seems to be reproducible 3 out of 5 times.

Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Priority: -- → P3
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/18f07982ab28
Check entire policy for empty objects. r=mconley

Backed out changeset 18f07982ab28 (bug 1600007) for failing at browser_policy_bookmarks.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/bcedfb13f4b2591a811e4dd693c479218e2cd24c

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=18f07982ab28d3a25b301d9dd06c547dd47fe7bb&selectedJob=279446718

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279446718&repo=autoland&lineNumber=2915

Log snippet:

[task 2019-12-03T23:35:12.496Z] 23:35:12 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_bookmarks.js | URL matches -
[task 2019-12-03T23:35:12.496Z] 23:35:12 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_bookmarks.js | Correctly placed -
[task 2019-12-03T23:35:12.497Z] 23:35:12 INFO - Leaving test bound test_revert_to_original_policy
[task 2019-12-03T23:35:12.497Z] 23:35:12 INFO - Entering test bound test_empty_all_bookmarks
[task 2019-12-03T23:35:12.497Z] 23:35:12 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_bookmarks.js | Sanity check the temporary file doesn't exist. - true == true -
[task 2019-12-03T23:35:12.502Z] 23:35:12 INFO - Buffered messages finished
[task 2019-12-03T23:35:12.502Z] 23:35:12 INFO - TEST-UNEXPECTED-FAIL | browser/components/enterprisepolicies/tests/browser/browser_policy_bookmarks.js | Test timed out -
[task 2019-12-03T23:35:12.503Z] 23:35:12 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_bookmarks.js | Engine is inactive at the end of the test -
[task 2019-12-03T23:35:12.503Z] 23:35:12 INFO - GECKO(1953) | MEMORY STAT | vsize 7643MB | residentFast 341MB | heapAllocated 105MB
[task 2019-12-03T23:35:12.503Z] 23:35:12 INFO - TEST-OK | browser/components/enterprisepolicies/tests/browser/browser_policy_bookmarks.js | took 45115ms
[task 2019-12-03T23:35:12.503Z] 23:35:12 INFO - checking window state

Flags: needinfo?(mozilla)

I'm seeing this failure without my patch as well. Are you?

Flags: needinfo?(mozilla)

I've done a clean build without my patch and I'm definitely seeing new intermittents in browser_policy_bookmark.js that weren't there before.

Did you see these with any other checkin?

Flags: needinfo?(rgurzau)

Never mind, definitely me.

Flags: needinfo?(rgurzau)
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/6a6a05869aea
Check entire policy for empty objects. r=mconley
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73

Hello,

I have checked this issue 73.0a1(id:20191205215330) with AVAST Free Antivirus on Windows 10x64 and confirming it as verified fixed.

I have tried to reproduce this 10 times and each time the correct outcome was encountered.

Status: RESOLVED → VERIFIED

Is this something we want to uplift?

Flags: needinfo?(mozilla)

Comment on attachment 9113289 [details]
Bug 1600007 - Check entire policy for empty objects. r?mconley

Beta/Release Uplift Approval Request

  • User impact if declined: There are cases where policies are marked active even though there are no active policies.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Policy only, tested and has automated test.
  • String changes made/needed:

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy related
  • User impact if declined: There are cases where policies are marked active even though there are no active policies.
  • Fix Landed on Version: 72
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Policy only, tested and has automated test.
  • String or UUID changes made by this patch:
Flags: needinfo?(mozilla)
Attachment #9113289 - Flags: approval-mozilla-esr68?
Attachment #9113289 - Flags: approval-mozilla-beta?

Comment on attachment 9113289 [details]
Bug 1600007 - Check entire policy for empty objects. r?mconley

approved for 72.0b6

Attachment #9113289 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Hello,

I have checked this issue on72.0b6(id:20191212210843) with AVAST Free Antivirus on Windows 10x64 and confirming it as verified fixed.

Comment on attachment 9113289 [details]
Bug 1600007 - Check entire policy for empty objects. r?mconley

Enterprise policy update, approved for 68.4esr.

Attachment #9113289 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+

Hello,

I have checked this issue on 68.4.0esr(ID:20191230131429) with AVAST Free Antivirus on Windows 10x64 and confirming it as verified fixed.

Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.