Closed Bug 1599769 Opened 5 years ago Closed 4 years ago

Ship Promise.any

Categories

(Core :: JavaScript: Standard Library, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: anba, Assigned: jorendorff)

References

(Depends on 1 open bug, Blocks 1 open bug, )

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

For now this bug just serves as a tracking issue, because there are still some open questions in the proposal repository, which need to be resolved before we can actually try to ship this feature.

No longer depends on: 1599435
Depends on: 1599435
Priority: -- → P3
Depends on: 1612730
Depends on: 1568903
See Also: → 1633780

We're passing the tests for this in Nightly. Let's ship it.

Assignee: nobody → jorendorff
Priority: P3 → P1

I'm a bit hesitant to ship this now, because then it'll end up in Firefox 78, which is an ESR release, so when TC39 reaches a decision on https://github.com/tc39/proposal-promise-any/issues/38, we may end up in a situation where our ESR release ships with an outdated implementation. Unless we're okay with that resp. we're okay with backporting the final approved Promise.any spec to ESR.

The logical assignment proposal has a similar issue, where TC39 still needs to reach a conclusion for an open spec report: https://github.com/tc39/proposal-logical-assignment/issues/23.

Since Firefox 78 doesn't go to release until June 30, I wonder if we can get both of these issues resolved in the next TC39 meeting taking place June 1-4. I see the logical assignment issue is already on the TC39 agenda. A discussion of Promise.any is also on the agenda, but for a different issue, so maybe we could add this issue as well.

78 will be in Beta at that point, meaning if we land both these features now, we have options for each:

  • No spec change = let it ride to release 78
  • Spec change = uplift change to beta 78, ride to release (assuming change isn't too big)
  • Spec issue unresolved = assess risk of riding to 78 as-is possibly backporting changes to ESR (vs. uplifting a change to pref off in 78)

:yulia, thoughts on this plan from a TC39 perspective?

Flags: needinfo?(ystartsev)

The previous changeset made a change to test262-update.py. This changeset is
the result of running the script, like this:

cd js/src/tests
python test262-update.py --revision 25c9e334d301944537215caba1d7f44319f3e0da

The revision is taken from the first line of js/src/tests/test262/GIT-INFO; the
purpose of specifying that revision is to run the script again using the same
input, so that the output reflects only changes to the script itself, not new
tests.

Depends on D76393

This is planned for discussion at the upcoming plenary. I will update after we come to a decision ( https://github.com/tc39/agendas/blob/master/2020/06.md)

Flags: needinfo?(ystartsev)
Depends on: 1641355

Discussion in tc39/proposal-promise-any#38 indicates this has been resolved informally ahead of the plenary; blocking bug 1641355 adjusts our behavior accordingly.

Issue 38 has been discussed by the committee, and will be resolved by https://github.com/tc39/proposal-promise-any/pull/64, which should allow us to move forward.

There is an overarching concern that hasn't been addressed yet but won't affect our work here.

Depends on: 1643397
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c3c837a5bf38
Part 1: Ship Promise.any. r=jwalden.
https://hg.mozilla.org/integration/autoland/rev/249e60b52fb4
Part 2: Update test262 tests. r=jwalden
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9ae34f20fbe
Part 1: Ship Promise.any. r=jwalden.
https://hg.mozilla.org/integration/autoland/rev/0b491b101124
Part 2: Update test262 tests. r=jwalden
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
Flags: needinfo?(jorendorff)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: