Closed Bug 1596091 Opened 4 years ago Closed 4 years ago

Implement the ability to drag and drop requests in order to block them

Categories

(DevTools :: Netmonitor, enhancement, P3)

enhancement

Tracking

(firefox71 wontfix, firefox72 wontfix, firefox78 verified)

VERIFIED FIXED
Firefox 78
Tracking Status
firefox71 --- wontfix
firefox72 --- wontfix
firefox78 --- verified

People

(Reporter: csasca, Assigned: lelouch.cpp)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Affected versions

  • 72.0a1
  • 71.0b9

Affected platforms

  • All could benefit

Steps to reproduce

  • devtools.netmonitor.features.requestBlocking - pref set on true
  1. Launch Firefox, open DevTools - Blocking tab;
  2. Click and hold on one request in the list
  3. Drag it into the blocking list

Enhancement suggestion

  • This method would be easier to use instead of right clicking and then selecting "Block URL"

Actual result

  • A request can only be blocked by manually entering the address in the blocking list, or by right clicking on the request and blocking it from there.

Regression range

  • Not a regression
Blocks: 1583111

Nice, I like the idea!
Honza

Priority: -- → P3

I would love to work on this issue if it is still up for grabs.
Thank you.
Kriyszig

We don't have any dragging right now in Network panel, so I am not sure how this would be discovered.

Better to discover might be a block option in the details pane (like Edit & Resend), which offers to block the origin, origin + path or full URL. I did mock that up as part of https://github.com/firefox-devtools/ux/issues/116#issuecomment-603010405 .

The does seem like a good alternative!
Given the initial click for dragging does toggle on the details pane.
Having it there would definitely have better discoverability.
Maybe a new enhancement?!

Drag and drop is a nice little feature to have to add URL to blocked
list. Current implementation allows for blocking the URL from the
context menu but drag and drop is a nifty little feature for
convenience.
Current implementation will only allowed an unblocked URL to be
dragged and dropped. The dragging is blocked is the network
blocking panel isn't opened.
Note: This is just an RFC. @Harald had raised a question of
discoverabilty of the feature given there are no other elements
that can be dragged and dropped within the network monitor. This
is just a proposal to see if it's addition is beneficial.

Assignee: nobody → lelouch.cpp
Status: NEW → ASSIGNED
Attachment #9147043 - Attachment description: Bug 1596091 - RFC: Adding drag and drop feature to block URL in netmonitor r=Honza,Harald → Bug 1596091 - RFC: Adding drag and drop feature to block URL in netmonitor r=Honza,Harald,bomsy
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/093094fd464c
RFC: Adding drag and drop feature to block URL in netmonitor r=Honza,Harald,bomsy
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
Flags: qe-verify+
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: