Closed Bug 1595942 Opened 5 years ago Closed 2 years ago

Tree status: Page sits at loading when logged in

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: iannbugzilla, Unassigned)

Details

Attachments

(1 file)

Steps to reproduce
1/ Go to https://treestatus.mozilla-releng.net/static/ui/treestatus/
2/ Page displays status of trees
3/ Click Login and login using email address and Auth0
4/ After login page redirects back to https://treestatus.mozilla-releng.net/static/ui/treestatus/

Expected result
1/ Page displays status of trees

Actual result
1/ Page sits with blue Loading... bar

Tried clearing local storage as mentioned in Bug 1595376 but that makes no difference

I have the same problem.

Summary: Page sits at loading when logged in → Tree status: Page sits at loading when logged in

One of the things I have spotted is that when I do log in, instead of the correct domain for my email address it shows @mozilla.com (but that might be just how it is supposed to show).

Code sheriffs had to empty the local storage for Treestatus:

shift + f9 > local storage > right click a row > delete all

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #3)

Code sheriffs had to empty the local storage for Treestatus:

shift + f9 > local storage > right click a row > delete all

Yep, done that "Tried clearing local storage as mentioned in Bug 1595376 but that makes no difference"

Are there particular scopes needed in our profile for the new treestatus? I have a list of 270 in my profile so far, I could quote the relevant ones if I knew which particular ones...

Do you have these?

assume:mozilla-group:treestatus
assume:mozilla-group:vpn_treestatus
project:releng:services/treestatus/*

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #6)

Do you have these?

assume:mozilla-group:treestatus
assume:mozilla-group:vpn_treestatus
project:releng:services/treestatus/*

No, I have none of those.
Have stuff to do with assume:project:releng:ci-group and project:comm:thunderbird:releng

shift + f9 > local storage > right click a row > delete all

That didn't help me either.

Do you have these?

How do I check?

(In reply to Jorg K (GMT+2) from comment #8)

shift + f9 > local storage > right click a row > delete all

That didn't help me either.

Do you have these?

How do I check?

When you have logged in, click on the drop down by your login ID and select "Manage Profile" that should take you to https://firefox-ci-tc.services.mozilla.com/profile which includes a list of Scopes.

I have a whole heap, including

assume:mozilla-group:treestatus
assume:mozilla-group:vpn_treestatus
but not project:releng:services/treestatus/*

It still hangs for me.

Just chiming in that I seem to be running into this also. I'm seeing the same behavior, clokep@mozilla.com instead of clokep@gmail.com. My config seems to be Jorg's: I have the assume:mozilla-group:treestatus, assume:mozilla-group:vpn_treestatus. I don't seem to have project:releng:services/treestatus/*.

Any idea if there's something we can do about this? It gets a bit annoying during the comm-* merges (and I should say that #release-drivers has been super helpful, but I don't want to waste people's time if possible!) Thanks for your help!

Flags: needinfo?(aryx.bugmail)

Any news on this, still cannot see the tree status

It looks like https://github.com/mozilla-releng/treestatus/blob/ad4f317ba7bb2820532a00fe6510bca290d2632e/frontend/src/App/TreeStatus.elm#L548 treats having no scopes as still loading. I don't actually see that variable used anywhere, but it suggests that if the user has no scopes it won't try to continue.

I do notice, if I login with an account that does not have any treeherder scopes, the UI does not try to load any status from treestatus.

Note that if you aren't logged in, things do appear to be visible, so the only failure case I have seen is logged in but without any treestatus scopes.

Patrick, when you go to https://firefox-ci-tc.services.mozilla.com/profile , do you have

  • assume:mozilla-group:treestatus
  • assume:mozilla-group:vpn_treestatus
  • project:releng:services/treestatus/*
Flags: needinfo?(aryx.bugmail) → needinfo?(clokep)

I reconfirmed what we found above in comment 10 and comment 11:

I have:

  • assume:mozilla-group:treestatus
  • assume:mozilla-group:vpn_treestatus

I do not have:

  • project:releng:services/treestatus/*
Flags: needinfo?(clokep) → needinfo?(aryx.bugmail)

Rail, do you have insight why Patrick and others are missing project:releng:services/treestatus/* and can you get it for them (they manage the comm-* trees)?

Flags: needinfo?(aryx.bugmail) → needinfo?(rail)

Bug 1613551 for context on the permissions.

If it's not urgent, I can take a look at this on Tuesday (still PTOing).

https://hg.mozilla.org/ci/ci-configuration/file/b8b5b6c1683baa87f1ca1aaff9308dc711eb8a20/grants.yml#l2137 suggests that we need to add mode people to the thunderbird-sheriff group.

Flags: needinfo?(rail)

(In reply to Rail Aliiev [:rail] from comment #21)

https://hg.mozilla.org/ci/ci-configuration/file/b8b5b6c1683baa87f1ca1aaff9308dc711eb8a20/grants.yml#l2137 suggests that we need to add mode people to the thunderbird-sheriff group.

Also anyone should be able to see the treestatus, without having to log out, so if you don't have any treestatus permissions it should still show the tree status page and not loading...

(In reply to Ian Neal from comment #22)

Also anyone should be able to see the treestatus, without having to log out, so if you don't have any treestatus permissions it should still show the tree status page and not loading...

True. I think comment #14 is what we need to fix.

I'm hoping this will fix the immediate need for myself, Rob, and Ian that means we'll be able to open/close the comm-* trees.

Attachment #9138889 - Flags: review?(rail)
Comment on attachment 9138889 [details] [diff] [review]
Patch to add Ian, Rob, and myself as thunderbird-sheriff

LGTM. BTW, you can use phabricator and lando for this repo. Would be much easier. ;)
Attachment #9138889 - Flags: review?(rail) → review+

(In reply to Rail Aliiev [:rail] from comment #25)

Comment on attachment 9138889 [details] [diff] [review]
Patch to add Ian, Rob, and myself as thunderbird-sheriff

LGTM. BTW, you can use phabricator and lando for this repo. Would be much
easier. ;)

Thanks. I pushed this as https://hg.mozilla.org/ci/ci-configuration/rev/6caaf8f7850e0f6e86034690b8188f566436a571

Unfortunately I've never gotten phabricator to work.

Or check https://moz-conduit.readthedocs.io/en/latest/mozphab-linux.html
It's come a long way in the last year, and actually works very nicely nowadays.

I confirmed that I'm now able to modify the trees. I think we can close this if it is also working for Ian!

Magnus / Jorg, thanks for the info I'll talk to you both offline about this.

Flags: needinfo?(iann_bugzilla)

Yes, I can confirm it's now displaying as it should. Thanks for all your work to fix this.

Flags: needinfo?(iann_bugzilla)

I think we're good to close here but please re-open if I'm wrong.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Component: Applications: TreeStatus → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: