Closed Bug 1595772 Opened 4 years ago Closed 4 years ago

Overflow Menu not correctly aligned in Customize menu when using Compact Density

Categories

(Firefox :: Toolbars and Customization, defect)

Desktop
All
defect
Not set
minor

Tracking

()

VERIFIED FIXED
Firefox 72
Tracking Status
firefox-esr68 --- wontfix
firefox70 --- wontfix
firefox71 --- wontfix
firefox72 --- verified

People

(Reporter: atrif, Assigned: Gijs)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

Attached image overflow_001.png

Affected versions

  • 71.0b9 (20191111170815)
  • 72.0a1 (20191111215252)
  • 70.0.1 (20191030021342)

Affected platforms

  • Ubuntu 18.04
  • macOS 10.14
  • Windows 10x64

Steps to reproduce

  1. Open Firefox and go to Customize Menu.
  2. Select “Compact” from the “Density” dropdown.

Expected result

  • Overflow Menu is updated accordingly.

Actual result

  • Overflow Menu is displayed on the left side of the drop-down arrow.

Regression range

  • Reproducible with Firefox 62.0a1(20180509220105). I will search for one ASAP if there is one.

Additional Notes

  • Attached a screenshot with the issue.
  • The issue reproduces only in Customize Menu.
Has Regression Range: --- → no
Has STR: --- → yes

What platform and Firefox version is the screenshot taken on? There's also a gap between the arrow and the overflow panel itself, which I thought we fixed recently.

Flags: needinfo?(alexandru.trif)
Attached image overflow_002.png

Sorry I didn't notice that. The screenshot is taken on 70.0.1 (20191030021342) using Windows 10x64. Also adding a screenshot from the latest Nightly (20191112094307) and 71.0b9(20191111170815). It seems that there is no gap here.

Flags: needinfo?(alexandru.trif)

(In reply to Alexandru Trif, QA [:atrif] from comment #2)

Created attachment 9108102 [details]
overflow_002.png

Sorry I didn't notice that. The screenshot is taken on 70.0.1 (20191030021342) using Windows 10x64. Also adding a screenshot from the latest Nightly (20191112094307) and 71.0b9(20191111170815). It seems that there is no gap here.

OK, great. Then yeah, it'd be helpful to have a regression window here for the original issue. Note that the horizontal offset here has been broken and fixed at least once before so it may be tricky to figure out when it last broke...

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression

bug 1398103 changed the inner/outer padding on toolbar buttons and seems to have broken this.

Component: Toolbars and Customization → Theme
Regressed by: 1398103
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/74da59be7123
make overflow panel arrow position in customize mode more reliably correct, r=dao
Component: Theme → Toolbars and Customization
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

Hello!
Verified the issue using Firefox 72.0a1 (20191118093852) on Windows 10x64, macOS 10.15 and Ubuntu 18.04. The arrow from the overflow menu is correctly updated when changing the density settings in the Customize Menu.

Status: RESOLVED → VERIFIED
Has Regression Range: no → yes
You need to log in before you can comment on or make changes to this bug.