Open Bug 1595064 Opened 4 years ago Updated 1 year ago

Displayed inconsistent zoom level between zoom level from pdf page and reader mode vs. browser zoom controls

Categories

(Firefox :: Toolbars and Customization, defect, P5)

71 Branch
defect

Tracking

()

Tracking Status
firefox-esr78 --- wontfix
firefox-esr91 --- wontfix
firefox-esr102 --- fix-optional
firefox70 --- wontfix
firefox71 --- wontfix
firefox72 --- wontfix
firefox83 --- wontfix
firefox84 --- wontfix
firefox85 --- wontfix
firefox101 --- wontfix
firefox102 --- wontfix
firefox103 --- fix-optional

People

(Reporter: zstimi, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Attached image zoom.png

Affected versions

  • Firefox 71.0b8
  • Firefox 72.0a1
  • Firefox 70.0.1

Affected platforms

  • Ubuntu 16.04 x86
  • Windows 10 x64
  • macOS 10.13

Steps to reproduce

  1. Launch Firefox
  2. Access a pdf document or a wikipedia page in reader mode.
  3. From Hamburger Menu -> Customize, drag and drop the Zoom Level button next to the Address Bar.
  4. Zoom in/zoom out the page using the "+/-" Zoom Level options.

Expected result

  • Consistent zoom level displayed (between zoom level from pdf page and zoom level from browser zoom controls)

Actual result

  • Zoom level near address bar is functional but is inconsistent with zoom level from page.

Regression range
I will come back with regression ASAP.

Additional notes
*Attached a screenshot with the issue.

Has Regression Range: --- → no

Seems like a front-end issue with the browser zoom indicator. Not sure what the right component for that is, let's try Toolbars and Customization.

Possibly related to bug 1590445 (though not fixed by it)?

Component: Panning and Zooming → Toolbars and Customization
Product: Core → Firefox

Hmm, not sure if this is a bug or intended. We have separate handling for PDF/document zooming vs. browser zooming; will try to find a searchfox link if that'd be helpful. NI'ing asa and Jamie to decide if this is something worth modifying in other (ongoing) zoom changes.

EDIT: https://searchfox.org/mozilla-central/rev/e7c61f4a68b974d5fecd216dc7407b631a24eb8f/browser/base/content/browser-fullZoom.js#275
if you follow that applyToPref code, the handling for an undefined aValue argument is to reset zoom to the default (100%) browser level, leaving zooming on a PDF viewer page to the PDF viewer itself.

Flags: needinfo?(jteh)
Flags: needinfo?(asa)

My 2c: having separate handling for PDF vs. browser zooming, in and of itself, is fine. (As in, it may be nice to unify them, but that's more of an enhancement / aspirational.)

However, the current behaviour that pressing the (+) button next to the browser zoom indicator increases the PDF zoom, while leaving the browser zoom indicator at 100%, I think that's more clearly a bug.

(In reply to Botond Ballo [:botond] from comment #3)

However, the current behaviour that pressing the (+) button next to the browser zoom indicator increases the PDF zoom, while leaving the browser zoom indicator at 100%, I think that's more clearly a bug.

Why? How else would there be separate handling? It would be really confusing to have 2 separate levels of zoom, and trying to use the browser zoom with pdfjs doesn't actually work well. We do something similar with reader mode.

We could try and report the pdf zoom level in all the browser indicators (hamburger menu, custom zoom widget, in-navbar zoom control), but that may be non-trivial.

(In reply to :Gijs (he/him) from comment #4)

(In reply to Botond Ballo [:botond] from comment #3)

However, the current behaviour that pressing the (+) button next to the browser zoom indicator increases the PDF zoom, while leaving the browser zoom indicator at 100%, I think that's more clearly a bug.

Why? How else would there be separate handling? It would be really confusing to have 2 separate levels of zoom, and trying to use the browser zoom with pdfjs doesn't actually work well. We do something similar with reader mode.

We could try and report the pdf zoom level in all the browser indicators (hamburger menu, custom zoom widget, in-navbar zoom control), but that may be non-trivial.

Oh oops, I didn't read the part about the in-menu buttons changing the PDF level, I thought it was just meta +/-. I think if the hamburger menu buttons change the zoom but don't report it in the same "current zoom value" menu item, we should definitely either change the buttons to zoom the PDF viewer (or not zoom at all), or report the PDF zoom in the hamburger menu item. preliminarily, doesn't look like it'd be too horrible to do the latter.

(In reply to :Gijs (he/him) from comment #4)

(In reply to Botond Ballo [:botond] from comment #3)

However, the current behaviour that pressing the (+) button next to the browser zoom indicator increases the PDF zoom, while leaving the browser zoom indicator at 100%, I think that's more clearly a bug.

Why?

Because you're clicking a control in one part of the zoom indicator widget, and it doesn't have an effect on the zoom level displayed in the same widget.

How else would there be separate handling?

Well, pdf.js has its own (+) / (-) buttons. It would make sense for those buttons to affect the pdf.js zoom, while the browser zoom buttons affect the browser zoom (or perhaps they're disabled if we don't want to support them with pdf.js).

The alternative, "unified" model would be to have both sets of buttons update both indicators.

Anyways, I don't feel strongly about it, just explaining why I think users find the current behaviour confusing.

This is probably not something the a11y team will be able to take care of as part of the zoom work we're doing this quarter.

Flags: needinfo?(jteh)

Jonas, any chance you're interested in looking at this?

Flags: needinfo?(jonas.jenwald)
Regressed by: 786674
Priority: -- → P5

(In reply to :Gijs (he/him) from comment #8)

Jonas, any chance you're interested in looking at this?

I'm honestly not really sure what I'm being asked to do here, since for starters this "issue" affects Reader Mode too (as you mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1595064#c4)!?

While it would obviously be technically feasible to e.g. propagate the PDF Viewer zoom values to the Firefox menu, that's not going to be as simple as you'd probably wish. The reason is that the PDF Viewer, in addition to allow zooming to arbitrary percentage values, also supports a few "special" zoom values (i.e. "Automatic Zoom", "Actual Size", Page Fit", and "Page Width") which I cannot image would play nice with the zoom label in the Firefox menu.

Finally, I'm not sure that I really agree with labelling this a regression from bug 786674, since prior to that being fixed zooming via e.g. the Firefox menu didn't really work well at all with the PDF Viewer (again similar to Reader Mode).

Flags: needinfo?(jonas.jenwald)

(In reply to Morgan Reschenberg [:morgan] from comment #2)

Hmm, not sure if this is a bug or intended. We have separate handling for PDF/document zooming vs. browser zooming; will try to find a searchfox link if that'd be helpful. NI'ing asa and Jamie to decide if this is something worth modifying in other (ongoing) zoom changes.

I don't think we should tackle PDF zooming if it's implemented separately.

Flags: needinfo?(asa)

Hi,
This also happens on ubuntu 18, FF 84.0b6.

Regards, Flor.

Has Regression Range: no → yes

Encountered the same issue on a wikiepedia page clicking on reader view button from URL bar and zooming this page, doesn't display the zoom level change neither in URL bar nor in hamburger menu. Testing this on Firefox 102.0esr build and on Firefox 102.0 RC, Ubuntu 20 and macOS 12.

Summary: Displayed inconsistent zoom level between zoom level from pdf page and browser zoom controls → Displayed inconsistent zoom level between zoom level from pdf page and reader mode vs. browser zoom controls
See Also: → 1792760
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.