Closed Bug 1594662 Opened 4 years ago Closed 4 years ago

[RTL builds] The Celebration Toast banner is not displayed

Categories

(Firefox :: Protections UI, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox71 --- affected
firefox72 --- affected

People

(Reporter: obotisan, Assigned: ewright)

References

Details

Attachments

(1 file)

Affected versions

  • Firefox 72.0a1
  • Firefox 71.0b7

Affected platforms

  • Windows 10x64
  • Ubuntu 18.04 x64
  • macOS 10.13

Prerequisites

  • Set "browser.contentblocking.cfr-milestone.milestones" pref to "[15, 5000, 10000, 25000, 50000, 100000, 500000]"
  • Set "browser.contentblocking.cfr-milestone.milestone-achieved" to "1000"
  • Set "browser.newtabpage.activity-stream.asrouter.providers.cfr" to {"id":"cfr","enabled":true,"type":"local","localProvider":"CFRMessageProvider","frequency":{"custom":[{"period":"daily","cap":10}]},"categories":["cfrAddons","cfrFeatures"],"updateCycleInMs":3600000}

Steps to reproduce

  1. Open an ar build.
  2. Go to reddit.com and refresh the page a few times.

Expected result

  • The Celebration Toast banner is displayed.

Actual result

  • The Celebration Toast is not displayed.

Regression range

  • This is not a regression.

Additional notes

  • In about:protection the trackers are counted.
    *It's possible that issue is reproducing on other RTL builds, but as far as we could tell on he builds the issue is not reproducing.
Assignee: nobody → ewright
Status: NEW → ASSIGNED
Priority: -- → P1

Using an Arabic build, I was able to trigger the milestone to show both on the new tab devtools page and on https://senglehardt.com/test/trackingprotection/test_pages/tracking_protection.html

the prefs that should be set are:

  • Set "browser.contentblocking.cfr-milestone.milestones" pref to "[1, 5000, 10000, 25000, 50000, 100000, 500000]"
  • "browser.contentblocking.cfr-milestone.milestone-achieved" to "0"
  • Set "browser.newtabpage.activity-stream.asrouter.providers.cfr" to {"id":"cfr","enabled":true,"type":"local","localProvider":"CFRMessageProvider","frequency":{"custom":[{"period":"daily","cap":10}]},"categories":["cfrAddons","cfrFeatures"],"updateCycleInMs":3600000}
  • Set "browser.contentblocking.cfr-milestone.update-interval" to 10

Oana, can you verify this?
note that if you visit a page with fingerprinters/social/crfyptominers you might trigger one of those CFR messages first, so I went to "https://senglehardt.com/test/trackingprotection/test_pages/tracking_protection.html" to ensure it will only trigger this message

Flags: needinfo?(oana.botisan)
Attached image numbers not arabic.gif

I tried with the same steps and with the prefs from comment 1 on Windows 10 x64 using Firefox 71.0b8. The doorhanger wasn't triggered.
Only when I changed the pref: "browser.contentblocking.cfr-milestone.milestones" from "[1, 5000, 10000, 25000, 50000, 100000, 500000]" to "[20, 5000, 10000, 25000, 50000, 100000, 500000]" on the same profile, the doorhanger was triggered.
I would like to mention that the numbers in about:protections and in about:config (when trying to change the value of any pref) are not Arabic. I think it might be a translation error or something related to that. This might be the reason the issue is reproducing. Please look at the attached gif.

Flags: needinfo?(oana.botisan)

(In reply to Oana Botisan, Desktop Release QA from comment #2)

I would like to mention that the numbers in about:protections and in about:config (when trying to change the value of any pref) are not Arabic. I think it might be a translation error or something related to that. This might be the reason the issue is reproducing. Please look at the attached gif.

Localizers don't have control on either of those, so it's not a translation error.

The fact that numbers are displayed with western numerals in about:protections seems like a bug to me, but also unrelated to the issue.

(In reply to Oana Botisan, Desktop Release QA from comment #2)

Only when I changed the pref: "browser.contentblocking.cfr-milestone.milestones" from "[1, 5000, 10000, 25000, 50000, 100000, 500000]" to "[20, 5000, 10000, 25000, 50000, 100000, 500000]" on the same profile, the doorhanger was triggered.

I believe this is the same issue as Bug 1593258. You need to navigate to 4+ pages first, then reset "browser.contentblocking.cfr-milestone.milestone-achieved" to "0". This will be fixed in the patch I posted in that bug.

On Nightly 72.0a1 the issue seems to be fixed, but I can still reproduce this issue using Firefox 71.0b11 on Windows 10 x64.

Excellent, it has been fixed with Bug 1593258, I'll ask for uplift on that bug.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.