Debugger - Log on Events text_description not centered with the button
Categories
(DevTools :: Debugger, enhancement, P3)
Tracking
(firefox70 unaffected, firefox71 wontfix, firefox72 wontfix, firefox73 wontfix, firefox74 verified)
Tracking | Status | |
---|---|---|
firefox70 | --- | unaffected |
firefox71 | --- | wontfix |
firefox72 | --- | wontfix |
firefox73 | --- | wontfix |
firefox74 | --- | verified |
People
(Reporter: cfogel, Assigned: aarushivij)
References
Details
(Keywords: good-first-bug)
Attachments
(2 files)
Affected versions
- 71.0b7, 72.0a1 (2019-11-05);
Affected platforms
- all
Steps to reproduce
- Launch Firefox, enable DevTools; access the Debugger tab;
- Lookup @ the breakpoints the Event Listener Breakpoints;
- (for reference) Expand the section;
Expected result
- center the button and text;
Actual result
- text for the Log feature is at the base of the button, not centered;
Regression range
- Pushlog URL;
- Not a regression, visible with introduction of monitorEvents/Event Tracing feature in bug 1110276;
Additional notes
- 70.0.1 not affected;
- see screenshot for reference.
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
I am completely lost in the mercurial docs. I am not quite sure where exactly to look I am getting alot of different information.
so far
- I've made the changes
- Create a book mark using
hg bookmark bug-1594374
- Commited changes locally using vscode
hg
integration.
Now when I try to push the changes using hg push -B
I get abort: authorization failed
. I am not quite sure what I can do about that or anything else I need to do. Any help/refer to specific parts on docs is welcome
Comment 3•4 years ago
|
||
Your goal here is to post your changes to Phabricator for review.
You can read this docs:
https://docs.firefox-dev.tools/contributing/code-reviews-setup.html
Here is what you can try:
-
Use
hg commit -m "Bug 1594374 - Debugger - Log on Events text_description not centered with the button"
to commit your changes in your working directory into your local HG repo -
Use
arc diff .^ --create
to upload the last commit to phabricator -
Use
arc diff .^ --update D<####>
to update the specific revision in phabricator
Honza
Assignee | ||
Comment 4•4 years ago
|
||
Hello,
I am new to open source development , and want to take it as my first bug.
Can I work on it?
Thanks :)
Comment 5•4 years ago
|
||
assigning the bug to Aarushi since we didn't hear from shavindra in the last 3 months.
Assignee | ||
Comment 6•4 years ago
|
||
Thank you :)
I have reproduced the bug and shall try solving it henceforth.
Shall come up with the updates soon
Assignee | ||
Comment 7•4 years ago
|
||
Assignee | ||
Comment 8•4 years ago
|
||
Hello
I have solved the bug and used commands in comment 3 to post a review on phabricator.
I did not know who to tag for review.
Please check it out :)
Thanks
Comment 9•4 years ago
|
||
Thanks for the help with this!
I just set a reviewer for the patch.
Honza
Comment 10•4 years ago
|
||
Pushed by pbrosset@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/599a56867430 Debugger - Log on Events text_description not centered with the button r=jlast
Comment 11•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Updated•4 years ago
|
Comment 12•4 years ago
|
||
Reproduced the initial issue on Firefox 71.0b10 and verified as fixed using Firefox 74.0b1 and the latest Nightly 75.0a1 - on Windows 10x64, Ubuntu 18.04x64 and Mac OS X 10.15
Updated•4 years ago
|
Description
•