Closed Bug 1594374 Opened 5 years ago Closed 4 years ago

Debugger - Log on Events text_description not centered with the button

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox70 unaffected, firefox71 wontfix, firefox72 wontfix, firefox73 wontfix, firefox74 verified)

VERIFIED FIXED
Firefox 74
Tracking Status
firefox70 --- unaffected
firefox71 --- wontfix
firefox72 --- wontfix
firefox73 --- wontfix
firefox74 --- verified

People

(Reporter: cfogel, Assigned: aarushivij)

References

Details

(Keywords: good-first-bug)

Attachments

(2 files)

Attached image debugger_logButton.png

Affected versions

  • 71.0b7, 72.0a1 (2019-11-05);

Affected platforms

  • all

Steps to reproduce

  1. Launch Firefox, enable DevTools; access the Debugger tab;
  2. Lookup @ the breakpoints the Event Listener Breakpoints;
  3. (for reference) Expand the section;

Expected result

  • center the button and text;

Actual result

  • text for the Log feature is at the base of the button, not centered;

Regression range

  • Pushlog URL;
  • Not a regression, visible with introduction of monitorEvents/Event Tracing feature in bug 1110276;

Additional notes

  • 70.0.1 not affected;
  • see screenshot for reference.
Has STR: --- → yes
Priority: -- → P3

I would like to work on this.

Flags: needinfo?(jlaster)
Assignee: nobody → shavindra
Flags: needinfo?(jlaster)

I am completely lost in the mercurial docs. I am not quite sure where exactly to look I am getting alot of different information.
so far

  1. I've made the changes
  2. Create a book mark using hg bookmark bug-1594374
  3. Commited changes locally using vscode hg integration.

Now when I try to push the changes using hg push -B I get abort: authorization failed. I am not quite sure what I can do about that or anything else I need to do. Any help/refer to specific parts on docs is welcome

Flags: needinfo?(odvarko)

Your goal here is to post your changes to Phabricator for review.

You can read this docs:
https://docs.firefox-dev.tools/contributing/code-reviews-setup.html

Here is what you can try:

  1. Use hg commit -m "Bug 1594374 - Debugger - Log on Events text_description not centered with the button" to commit your changes in your working directory into your local HG repo

  2. Use arc diff .^ --create to upload the last commit to phabricator

  3. Use arc diff .^ --update D<####> to update the specific revision in phabricator

Honza

Flags: needinfo?(odvarko)

Hello,
I am new to open source development , and want to take it as my first bug.
Can I work on it?
Thanks :)

assigning the bug to Aarushi since we didn't hear from shavindra in the last 3 months.

Assignee: shavindra → aarushivij
Status: NEW → ASSIGNED

Thank you :)
I have reproduced the bug and shall try solving it henceforth.
Shall come up with the updates soon

Hello
I have solved the bug and used commands in comment 3 to post a review on phabricator.
I did not know who to tag for review.
Please check it out :)
Thanks

Thanks for the help with this!
I just set a reviewer for the patch.

Honza

Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/599a56867430
Debugger - Log on Events text_description not centered with the button r=jlast
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
Flags: qe-verify+

Reproduced the initial issue on Firefox 71.0b10 and verified as fixed using Firefox 74.0b1 and the latest Nightly 75.0a1 - on Windows 10x64, Ubuntu 18.04x64 and Mac OS X 10.15

Flags: qe-verify+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: