Closed Bug 1593343 Opened 5 years ago Closed 3 years ago

Marionette should not be enabled if no MOZ_MARIONETTE environment variable is set nor the --marionette argument specified

Categories

(Remote Protocol :: Marionette, defect, P2)

Version 3
defect

Tracking

(firefox88 fixed)

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(3 files, 1 obsolete file)

Marionette should only be started when the MOZ_MARIONETTE environment variable is set, or the --marionette argument is specified when starting Firefox.

Right now we save the Marionette enabled state in the preference marionette.enabled, which will never be reset. As such a next start of Firefox without those two methods will still cause Marionette to be enabled.

@Whimboo, I wish to work on this bug.

Sure. As usual let me know if you need more information. Thanks

Assignee: nobody → rishigpt2009
Status: NEW → ASSIGNED
Assignee: rishigpt2009 → nobody
Severity: critical → S2
Status: ASSIGNED → NEW

I think that I should care about it. Will have a look within the next days.

Mentor: hskupin
Whiteboard: [lang=js]

We probably can get rid of this preference, and work for that needs to be done on bug 1632821. If that's the case it will also fix this bug.

Depends on: 1632821
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P3 → P2
Attachment #9108796 - Attachment is obsolete: true
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c09023d5bd1
[telemetry] Stop recording of the "marionette.enabled" preference. r=chutten
https://hg.mozilla.org/integration/autoland/rev/2650e8bbdad0
[condprof] Remove usage of "marionette.enabled". r=perftest-reviewers,sparky
https://hg.mozilla.org/integration/autoland/rev/a32e1c5c8ad8
[marionette] Remove preference "marionette.enabled". r=marionette-reviewers,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
See Also: → 1459414
Blocks: 1699627
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: