Closed Bug 1593235 Opened 4 years ago Closed 4 years ago

"View Background Image" in PDF presentation mode results in a unusable browser window

Categories

(Firefox :: PDF Viewer, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 75
Tracking Status
firefox-esr68 --- unaffected
firefox70 --- unaffected
firefox71 --- wontfix
firefox72 --- wontfix
firefox73 --- wontfix
firefox74 --- wontfix
firefox75 --- fixed

People

(Reporter: cbadau, Assigned: Snuffleupagus)

References

Details

(Keywords: regression)

Attachments

(3 files)

Attached image issue.gif

Affected versions

  • Firefox 71 Beta 6
  • latest Nightly 72.0a1 (2019-10-31)
  • 71.0b1 DevEdition

Affected platforms

  • Windows 10 x64
  • Windows 8.1 x64
  • Ubuntu 18.04 x64
  • macOS 10.15

Steps to reproduce

  1. Launch Firefox and open a pdf page (e.g.: http://www23.statcan.gc.ca/imdb-bmdi/pub/instrument/3901_Q2_V3-eng.pdf).
  2. Click the Presentation Mode button to enter in full screen mode.
  3. Right click to open context menu and select "View Background Image" option.

Expected result

  • The browser switch back to Normal mode (exits the Presentation Mode) and the page with background image is displayed.

Actual result

  • The page with background image is displayed, but you don't have any option to exit from here or to switch back to normal mode. Please see attachment "issue.gif". The only actions you can do here are to Restart browser or to Close browser.

Regression range

  • This is a recent regression. The issue is NOT reproducible on Firefox 70.0.1, but it is reproducible on Developer Edition 71.0b1. I will come back with the complete regression range ASAP.

Additional notes

  • The issue is NOT reproducible on Windows 7 x64.
Has Regression Range: --- → no
Has STR: --- → yes

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression

We should probably just morph this into a "remove the context menu option".

Flags: needinfo?(bdahl)
Summary: "View Background Image" doesn't work properly for PDFs in Presentation mode → "View Background Image" in PDF presentation mode results in a unusable browser window
Attached patch bug1593235.diffSplinter Review

(In reply to Jim Mathies [:jimm] from comment #2)

We should probably just morph this into a "remove the context menu option".

In that case, this bug is probably a duplicate of bug 1498555.

Given that the "View Background Image" never makes sense in the PDF Viewer, as far as I'm concerned, always hiding the context menu entry seems reasonable. Assuming that's the direction you want to go here, I can see about submitting a proper patch later.

The patch above seems reasonable.
Jonas, want to open a phabricator review request?

Flags: needinfo?(bdahl) → needinfo?(jonas.jenwald)
Priority: -- → P2

Given that the "View Background Image" option never makes sense in the PDF Viewer, it's simply always removed from the context menu.

(In reply to Brendan Dahl [:bdahl] from comment #5)

The patch above seems reasonable.
Jonas, want to open a phabricator review request?

Thanks; I've submitted a patch the correct way now :-)

I also tried, to the best of my ability, to add a new test for this and hopefully it actually makes sense.

Flags: needinfo?(jonas.jenwald)

This is an edge case and our last beta goes to build this Thursday. If the patch lands on nightly before I would be happy to consider an uplift but I am marking it as fix-optional for 71 given that the beta cycle is coming to an end.

Too late for a fix in 72, happy to take a patch for 74. I'm marking the bug fix-optional to remove it from weekly regression triage.

Assignee: nobody → jonas.jenwald
Status: NEW → ASSIGNED
Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/832da9d56b03
Hide the "View Background Image" context menu option in the PDF Viewer. r=bdahl
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
You need to log in before you can comment on or make changes to this bug.