Closed Bug 1591413 Opened 5 years ago Closed 5 years ago

Menu Bar context menu is displayed when right clicking on search suggestions dropdown (from Address Bar)

Categories

(Firefox :: Address Bar, defect, P1)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 72
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox69 --- unaffected
firefox70 --- wontfix
firefox71 --- verified
firefox72 --- verified

People

(Reporter: cbadau, Assigned: Gijs)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

issue.png
73.44 KB, image/png
Details
Bug 1591413 - block context menu in the urlbar view, r?dao
47 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review
Attached image issue.png —

Affected versions

  • latest Nightly 72.0a1 (2019-10-25)
  • Firefox 71 Beta 4
  • Firefox 70 RC build 2

Affected platforms

  • Windows 7 x64
  • macOS 10.14
  • Ubuntu 18.04 x64

Steps to reproduce

  1. Launch Firefox.
  2. Type something in the Address bar/URL bar (e.g. moz).
  3. Right click on a result (search suggestion) from dropdown.

Expected result

  • No context menu displayed.

Actual result

  • The context menu from Menu Bar is displayed. Please see attachment "issue.png"

Regression range

  • I will come back ASAP with regression range.

Additional notes

  • The issue is NOT reproducible on Firefox 69.0.3.
Component: Search → Address Bar
Priority: -- → P1

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=47e72c204ef61c34509e430c0976f4db680e384a&tochange=580d975db59096011e93150a04856a15b9e8812d

Regressed by: 580d975db59096011e93150a04856a15b9e8812d Dão Gottwald — Bug 1551598 - Stop using a popup window for urlbar results. r=mak

Has Regression Range: --- → yes
Has STR: --- → yes
Keywords: regressionwindow-wanted → regression
Regressed by: 1551598
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ba8cafef60a8
block context menu in the urlbar view, r=dao

https://hg.mozilla.org/mozilla-central/rev/ba8cafef60a8

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

Comment on attachment 9104555 [details]
Bug 1591413 - block context menu in the urlbar view, r?dao

Beta/Release Uplift Approval Request

  • User impact if declined: Non-applicable context menu in the URL bar popup
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: n/a
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): 1-line well-understood markup fix to avoid the toolbar's context menu applying to the URL bar "popup"
  • String changes made/needed: nope
Attachment #9104555 - Flags: approval-mozilla-beta?

Comment on attachment 9104555 [details]
Bug 1591413 - block context menu in the urlbar view, r?dao

P1, one-liner markup patch, uplift approved for 71 beta 6, thanks.

Attachment #9104555 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Verified fixed on Windows 7 x64, Ubuntu 18.04 x64 and macOS 10.15 using Firefox 71 Beta 6 and latest Nightly 72.0a1 (2019-11-01).

Status: RESOLVED → VERIFIED
status-firefox71: fixed → verified
status-firefox72: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: