Open Bug 1590720 Opened 5 years ago Updated 1 year ago

Netmonitor blocking - add focussed styling when selecting a tab via TAB navigation

Categories

(DevTools :: Netmonitor, enhancement, P3)

enhancement

Tracking

(firefox71 affected, firefox72 affected)

Tracking Status
firefox71 --- affected
firefox72 --- affected

People

(Reporter: cfogel, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Affected versions

  • 72.0a1 (2019-10-22), 71.0b3

Affected platforms

  • all could benefit;

Steps to reproduce
devtools.netmonitor.features.requestBlocking - pref set on true

  1. Launch Firefox, open DevTools - Blocking tab;
  2. Add several blocking patterns to the list by any means(4-5 would suffice);
  3. Click on the first patten;
  4. Repeat until reaching last one;

Enhancement suggestion

  • attached a quick mock-up of the suggestion, similar styling from the on_hover effects;
  • some extra styling change would be needed to make the active element clearer;
  • the fact that the X-remove button is displayed doesn't seem enough when the desire is to toggle on/off a filter;

Actual result

  • X button for the filter displayed but pressing tab one more time jumps on the next filter;

Regression range

  • not a regression

I'm not sure I understood the problem fully.
Is this about the style used for checkboxes when focused using the keyboard (Tab navigation)?

On macOS it looks rather distinctive, but I'm not sure what it looks like on Windows. Linux: will depend on the GTK theme that is used, I suspect.

If we reframe this as a user story, e.g. "As a keyboard user I want to be able to disable or enable an existing blocking pattern, edit its value, or remove it", my testing shows that:

  • Focusing and using the checkbox works. The focus style may be missing or hard to see on some platforms (to be confirmed).
  • Editing the pattern is not possible. The only way to edit, right now, seems to be to double-click the row.
  • Removing is possible: the "remove" button has a distinctive focus style and can be activated with the keyboard (Enter or Space).

Thanks for the prompt reply!

Yes, you got it right. Functionality is not hindered just the UI polish that feels needed.
In all fairness I didn't double check with macOS, since I didn't expect it to be implemented like that.

With Windows and Ubuntu the "issue" is as noted.
Still, having similar styling as in the case of the macOS would probably be to much for the other OS_users.

As for the edit part, was about to file another enhancement with it as well. It would be a bit more comfortable to use with this addition.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.