Netmonitor - Learn more about Performance analysis button can be aligned with the Cache Headers
Categories
(DevTools :: Netmonitor, enhancement, P3)
Tracking
(firefox-esr60 wontfix, firefox-esr68 wontfix, firefox70 wontfix, firefox71 wontfix, firefox72 wontfix, firefox105 fixed)
People
(Reporter: cfogel, Assigned: danielqeli1)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(5 files, 3 obsolete files)
Affected versions
- 72.0a1 (2019-10-22) , 70.0b3, 69.0.2, 68.1.0esr, 60.9.0esr;
Affected platforms
- Windows 10, macOS 10.13, Ubuntu 18.04;
Steps to reproduce
- Launch Firefox, open DevTools - Netmonitor;
- Access any webpage;
- Click on the StopWatch from the bottom-left corner of the screen (Start Performance Analisys);
Enchancement suggestion
- Learn more about Performance analysis button can be aligned with the Cache Headers
Actual result
- (?) button appears lower than the Cache text line;
Regression range
- not a regression, appears to be in the MDN mockups as is;
- refference;
Additional notes
- attached screenshot with the suggestion.
Updated•4 years ago
|
Comment 1•4 years ago
|
||
@Florens, perhaps this could be easy to fix?
Honza
Comment 2•4 years ago
•
|
||
Looks doable. Things to fix:
- The icon is misaligned in the button itself
- Button is misaligned with regards to the title
Comment 3•4 years ago
|
||
Comment 4•4 years ago
|
||
Result of the attached patch.
We were using a 24px icon scaled down to 16px, leaving us with a slightly too fat stroke for the circle, so tweaked the icon size and circle stroke to be more similar to e.g. the "info" icon in Console.
Also tweaked the MDN button to use a 20x20 total size, its vertical alignment in the searchbox, its vertical alignment in the Headers pane and in the Performance analysis pane.
One interesting win is that it does not make the "Status Code" line so much bigger now. (Ultimately I'd love to address the vertical rhythm and spacing in the Headers pane -- implementing Matt's design, probably -- but that's a different topic.)
Updated•4 years ago
|
Comment 5•3 years ago
|
||
This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.
Comment 7•2 years ago
|
||
Assigned to you, thank you for helping
Honza
Updated•2 years ago
|
Comment 10•2 years ago
|
||
Depends on D128790
Comment 11•2 years ago
|
||
Depends on D128813
Updated•2 years ago
|
Updated•2 years ago
|
Comment 12•2 years ago
|
||
Updated•2 years ago
|
Comment 15•2 years ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 16•2 years ago
|
||
Looks doable, I'll take this one
Assignee | ||
Comment 17•2 years ago
|
||
Depends on D150886
Updated•2 years ago
|
Updated•2 years ago
|
Comment 18•2 years ago
|
||
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7249cbd736d7 Fixed/improved alignment of "Learn more about performance" button with cache headers r=bomsy
Comment 19•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Description
•