Closed Bug 1590376 Opened 5 years ago Closed 2 years ago

Remove nsResizerFrame.cpp (resizer XUL element)

Categories

(Core :: Layout, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
103 Branch
Tracking Status
firefox103 --- fixed

People

(Reporter: ntim, Assigned: MatsPalmgren_bugz)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Ah, good catch. It should probably be moved out of layout/xul and be de-XULed then, given that the <resizer> element is only used as anon content in resizable HTML elements. We should also be explicit about not allowing <resizer> in other cases too.

Flags: needinfo?(ntim.bugs)

I'm mostly moving the code verbatim, but I excluded a few bits
that handled resizers inside menu popup frames, e.g.
https://searchfox.org/mozilla-central/rev/7bb1cc6abf6634b2a20f71935e1e519e73402b63/layout/xul/nsResizerFrame.cpp#165-170
I don't think we need that functionallity anymore and it
simplifies the code to exclude it.

Assignee: nobody → mats
Status: NEW → ASSIGNED
Blocks: 1694056
Blocks: 1694061

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:mats, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mats)
Flags: needinfo?(bugs)
Flags: needinfo?(bugs)
Flags: needinfo?(MatsPalmgren_bugz)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/00ed65f43cb2
part 1 - Add a XULResizerElement and move all nsResizerFrame's event handling code there.  r=ntim,smaug
https://hg.mozilla.org/integration/autoland/rev/f137d6e73641
part 2 - Remove (XUL) nsResizerFrame since it serves no purpose anymore.  r=emilio
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/656906f99173
Add missing include to un-bust non-unified builds.
Attachment #9204489 - Attachment description: Bug 1590376 part 1 - Add a XULResizerElement and move all nsResizerFrame's event handling code there. r=ntim → Bug 1590376 part 1 - Add a XULResizerElement and move all nsResizerFrame's event handling code there. r=ntim,smaug
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8fae0dee3f92
part 1 - Add a XULResizerElement and move all nsResizerFrame's event handling code there.  r=ntim,smaug
https://hg.mozilla.org/integration/autoland/rev/b11c52596655
part 2 - Remove (XUL) nsResizerFrame since it serves no purpose anymore.  r=emilio
Flags: needinfo?(emilio)
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: