NetMonitor blocking - manually added, disabled patterns are still blocking requests
Categories
(DevTools :: Netmonitor, defect, P2)
Tracking
(firefox70 unaffected, firefox71 verified, firefox72 verified)
Tracking | Status | |
---|---|---|
firefox70 | --- | unaffected |
firefox71 | --- | verified |
firefox72 | --- | verified |
People
(Reporter: cfogel, Assigned: davidwalsh)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
868.92 KB,
image/gif
|
Details | |
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
Affected versions
- 71.0a1 (2019-10-21)
Affected platforms
- Windows 10, macOS 10.13, Ubuntu 16.04;
Steps to reproduce
devtools.netmonitor.features.requestBlocking - pref set on true
- Launch Firefox, access https://www.wikipedia.org/
- enable the Netmonitor - Request Blocking section;
- In the blocking section add to block: wikipedia
- Refresh the page;
- Right click on the blocked request;
- Click on the Unblock option;
- Refresh the page.
Expected result
- request is not blocked;
- filter is still in list but checkbox empty;
Actual result
- request remains blocked;
- filter appears to be toggled off(checkbox) but remains active;
Regression range
- most likely not a regression, only visible after implementation of bug 1580728;
Additional notes
- added recording with the issue;
- manually toggling the filter has the desired effect;
Comment 1•5 years ago
|
||
Thanks for the report I can reproduce the issue on my machine (Win10, Nightly)
Honza
Assignee | ||
Comment 3•5 years ago
|
||
Comment 4•5 years ago
|
||
David, don't forget to assign bugs to yourself.
Honza
Comment 5•5 years ago
|
||
Bugbug thinks this bug is a regression, but please revert this change in case of error.
Pushed by dwalsh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7c8d02b4dca0 Ensure matched blocking URLs are sent to server r=Honza
Comment 7•5 years ago
|
||
bugherder |
Reporter | ||
Comment 8•5 years ago
|
||
Fix verified with 72.0a1 (2019-10-22).
71.0b3 still affected.
Comment 10•5 years ago
|
||
Comment on attachment 9103025 [details]
Bug 1590119 - Ensure matched blocking URLs are sent to server r=Honza
Beta/Release Uplift Approval Request
- User impact if declined: A key interaction in the new request blocking feature will be broken
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Verified by QA in Nightly. The fix is extremely simple.
- String changes made/needed:
Comment 11•5 years ago
|
||
Comment on attachment 9103025 [details]
Bug 1590119 - Ensure matched blocking URLs are sent to server r=Honza
Minimal patch fixing a visible bug in a new devtools feature, verified as fixed on Nightly by QA, uplift approved for 71 beta 4, thanks.
Comment 12•5 years ago
|
||
bugherder uplift |
Updated•5 years ago
|
Updated•5 years ago
|
Reporter | ||
Comment 13•5 years ago
|
||
Verified with 71.0b4 on macOS 10.13, Windows 10, Ubuntu 16.04.
Description
•