Closed Bug 1589109 Opened 5 years ago Closed 4 years ago

[Fission] - video-streams from https://gamingforgood.net/ cannot be toggled to fullscreen

Categories

(Core :: DOM: Navigation, defect, P2)

71 Branch
defect

Tracking

()

VERIFIED FIXED
Fission Milestone M5
Tracking Status
firefox71 --- wontfix
firefox75 --- verified

People

(Reporter: cfogel, Unassigned)

References

Details

Affected versions

  • 71.0a1 (2019-10-16)

Affected platforms

  • Windows 10, macOS 10.14, Ubuntu 16.04;

Steps to reproduce
Preconditions:

  • fission.autostart set to true;
  1. Access https://gamingforgood.net/s/staysafetv or any other stream from the website;
  2. Enable the audio for the stream(or wait 3-5 seconds);
  3. Click on the Fullscreen button for the stream;

Expected result

  • stream goes fullscreen;

Actual result

  • button is toggled but fullscreen does not go through;

Regression range

  • will check if one asap;

I tried to find a regression for this issue but I found that this is not a regression due to the fact that the fission.autostart option from the about:config menu was not visible in earlier versions of FX. Here is a pushlog from where the issue is reproducible https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ce56e2779818d25cfa2ac32f38ed84e6811d76a9&tochange=7e01c4d1cddcbbd4375fbd8b8909249b9ecb4eb6.

QA Whiteboard: [qa-regression-triage]

Fullscreen for Fission was done in bug 1505916. Abdoulaye, will you have some time to look into this?

Flags: needinfo?(ablayelyfondou)

Neha: this might be related to SetActiveWindow issue with Fission subframes. I will need a closer look to confirm.

Now, I can safely say this is a duplicate of Bug 1556627. Actually, if you move the focus (with Tab) to the subframe containing the video, fullscreen should work.

Moving the focus to that subframe can be irksome since there are a lot of elements in https://gamingforgood.net pages. So I have a simpler test case:

  1. Open http://fission-project.000webhostapp.com/html/test_fullscreen.html.
  2. unmute video
  3. Press tab once
  4. Click the "Enter fullscreen" button.
Flags: needinfo?(ablayelyfondou)
Flags: needinfo?(nkochar)

Thanks Abdoulaye. I'll mark this dependent on Bug 1556627 but will keep it open for now to ensure we verify once the focus patch lands.

Depends on: 1556627
Flags: needinfo?(nkochar)
Fission Milestone: --- → M5
Priority: -- → P2

Now that bug 1556627 is done, could we reverify that this is indeed fixed?

Flags: needinfo?(cristian.fogel)

Yes, it is working fine now.
Verified with 75.0a1 (2020-02-19) - Windows 10, macOS 10.15.3, Ubuntu 19.04.

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(cristian.fogel)
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.