Open Bug 1588070 Opened 5 years ago Updated 1 year ago

NetMonitor blocking - Indicate blocked requests yet before reload

Categories

(DevTools :: Netmonitor, enhancement, P3)

enhancement

Tracking

(firefox71 affected, firefox72 affected)

Tracking Status
firefox71 --- affected
firefox72 --- affected

People

(Reporter: cfogel, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Note

Affected versions

  • 71.0a1 (2019-10-10);

Affected platforms

  • all available

Steps to reproduce

  • devtools.netmonitor.features.requestBlocking set to true;
  1. Enable/access DevTools -> Network tab -> Request blocking section;
  2. Access any webpage;
  3. Right click on any request and click on the Block URL option;

Actual result

  • request is added to the Request blocking filters;

Enhancement suggestion

  • indicate the request is blocked in the main section as well:
  1. the blocked icon for the status field can be displayed, even if faded out or with the color white/grey;
  2. text could be colored as mentioned above;
  3. when hovering over the status the message could be updated to "Blocked after refresh"

Additional notes

  • main reasoning is that after blocking requests, with the Requests Blocking panel closed there is no other indicator that the request will be blocked;
  • while for Blocking a request the side-panel is displayed (each time if closed), Unblocking a request gives no feedback_indicator at all.

Thanks for the report!
Honza

Has STR: --- → yes
Priority: -- → P3

Updating flags for the current versions: 71.0b9, 72.0a1 (2019-11-12).

Could you weigh in here? I don't know what direction to take this.

Flags: needinfo?(victoria)

Sorry for the very late reply!

I see that this is a bit tricky - currently, this UI only communicates what was already recorded, not new behaviors that will occur upon refresh.

I like the idea of a grayed-out blocking icon when unblocking a request, but it seems potentially confusing to use when blocking. Maybe we can show both the status and the grayed out blocking icon, but I'd rather not make the status column any wider (especially considering new plans to merge it with the method col).

Tempted to say we add a blue/red indicator dot (like a 'dirty' file indicator) somewhere such as to the left of the filename. CC Harald in case he has ideas.

Flags: needinfo?(victoria) → needinfo?(hkirschner)

I agree better feedback would be nice. As a refresh is sensible for blocking to work maybe that could be recommended? But I would lean on waiting to get other user reports on this.

Flags: needinfo?(hkirschner)

This remains me "Future" breakpoints back on Venkman days.
Honza

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.