Closed Bug 1587042 Opened 5 years ago Closed 4 years ago

[linux] ETP toggle button pixelated on default (active) state

Categories

(Firefox :: Protections UI, defect, P3)

Desktop
Linux
defect

Tracking

()

VERIFIED FIXED
Firefox 72
Tracking Status
firefox-esr68 --- unaffected
firefox69 --- unaffected
firefox70 --- wontfix
firefox71 --- verified
firefox72 --- verified

People

(Reporter: cfogel, Assigned: nhnt11)

References

(Regressed 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(4 files)

Attached video 2019-10-08 14-03-38.mp4

Affected versions

  • 70.0b13, 71.0a1 (2019-10-07);

Affected platforms

  • Ubuntu 16.04

Steps to reproduce

  1. Launch Firefox, access any website with trackers;
  2. Click on the Shield button;
  3. Enable tracking protection if disabled

Expected result

  • button is properly displayed;

Actual result

  • button appears pixelated / low quality when enabled;
  • probably some on-hover residual styling on default state;

Regression range

Additional notes

  • attached recording to illustrate the issue with the issue;
  • Windows 7 and macOS 10.13, don't seem to be affected by this issue;
Has Regression Range: --- → yes
Has STR: --- → yes
Flags: needinfo?(nhnt11)
Regressed by: 1584633

Isn't everything pixelated in that video? I have an Ubuntu VM and on low resolutions (obviously) all the icons are pixelated, while they look fine on higher resolutions. Did you try fiddling with the display resolution? Are all the other icons sharp for you?

Flags: needinfo?(cristian.fogel)
Attached image 1587042_bad.png

Attaching screenshot with an affected build.

Flags: needinfo?(cristian.fogel)
Attached image 1587042_good.png

Attaching screenshot with an good build.

I think the issue is that --panel-separator-color evaluates to ThreeDShadow on Linux, and we're using this color on the border of the switch. We should probably check this out on Windows too... --panel-separator-color is set to ThreeDLightShadow there, but seems like it's overridden by a @media (-moz-windows-default-theme) block - gotta verify what -moz-windows-default-theme means.

Flags: needinfo?(nhnt11)
Priority: -- → P3

Nihanth, do you have plans to fix that in 72? Thanks

Flags: needinfo?(nhnt11)
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Flags: needinfo?(nhnt11)
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/49320c7fe8b3
Don't use --panel-separator-color for TP switch border. r=timhuang
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

Nihanth, do you think that this one line CSS fix could be uplifted to beta? If you do think it's safe, please request the uplift, thanks.

Flags: needinfo?(nhnt11)

Comment on attachment 9107457 [details]
Bug 1587042 - Don't use --panel-separator-color for TP switch border. r=timhuang!

Beta/Release Uplift Approval Request

  • User impact if declined: The ETP toggle switch in the Protections Panel looks pixelated/low-resolution on Linux.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See STR in comment 0 and screenshots in comment 2 and comment 3.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple CSS fix that makes the border color of the TP switch consistent on all platforms.
  • String changes made/needed:
Flags: needinfo?(nhnt11)
Attachment #9107457 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Comment on attachment 9107457 [details]
Bug 1587042 - Don't use --panel-separator-color for TP switch border. r=timhuang!

Low risk CSS fix, uplift approved for 71 beta 10, thanks.

Attachment #9107457 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Marking fix as verified for 72.0a1(2019.11.13).
Leaving QE+ flag up for Beta 10.

Verified with the 71.0b10 task_cluster build.
Thanks for the hotfix!

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Regressions: 1596720
You need to log in before you can comment on or make changes to this bug.