Closed Bug 1585942 Opened 5 years ago Closed 4 years ago

NetMonitor blocking - Request blocking inner margins hide content when section width decreases to minValue

Categories

(DevTools :: Netmonitor, defect, P3)

71 Branch
defect

Tracking

(firefox70 unaffected, firefox71 verified)

RESOLVED DUPLICATE of bug 1589272
Tracking Status
firefox70 --- unaffected
firefox71 --- verified

People

(Reporter: cfogel, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Attached image Netmonitor_minclip.gif

Affected versions

  • 71.0a1 (2019-10-02)

Affected platforms

  • all available;

Steps to reproduce

  • devtools.netmonitor.features.requestBlocking set to true;
  1. Enable/access DevTools -> Network tab -> Request blocking section;
  2. Add some filters/ block requests;
  3. Grab the panel's edge and move it to left (decreasing the width to the min_available);

Expected result

  • checkboxes + text for filters should still be visible;

Actual result

  • checkboxes + text is covered by the margins of the section;
  • hovering over still reveals the removal button;
  • main issue would be that it's an X button for nothing since even the tooltip is not visible anymore;

Regression range

  • not a regression, only visible after implementation of bug 1580728;

Additional notes

  • attached screenshot with the issue;

Thanks for the report I can reproduce that on my machine.
Honza

Priority: -- → P3
Has STR: --- → yes

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression

Not a regression
Honza

Keywords: regression

I would do a combined fix:

  • Use a min-width on the block list (e.g. 120px), so that it overflows on the right in extreme cases.
  • Configure the split view to use a maxWidth of ~80% or 90% at most (by default I believe it uses 95%, which means leaving a 50px width for the sidebar in a 1000px-wide viewport).

Thanks for the instructions Florens!
Honza

Keywords: good-first-bug

Moved to using min-width on that panel.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

Confirmed fix while checking bug 1587777.

Status: RESOLVED → VERIFIED
Status: VERIFIED → REOPENED
Resolution: FIXED → ---

Fixed in bug 1589272

Status: REOPENED → RESOLVED
Closed: 5 years ago4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.