Closed Bug 1585313 Opened 5 years ago Closed 4 years ago

NetMonitor blocking - [Win] Button for filter removal remains displayed if click+drag away action is issued

Categories

(DevTools :: Netmonitor, defect, P3)

71 Branch
All
Windows
defect

Tracking

(firefox70 unaffected, firefox71 wontfix, firefox76 verified)

RESOLVED FIXED
Firefox 76
Tracking Status
firefox70 --- unaffected
firefox71 --- wontfix
firefox76 --- verified

People

(Reporter: cfogel, Assigned: lelouch.cpp)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files)

Affected versions

  • 71.0a1 (2019-09-29)

Affected platforms

  • Windows 10

Steps to reproduce
devtools.netmonitor.features.requestBlocking set on true

  1. Launch Firefox, access any webpage, open the DevTools inspector - Network tab;
  2. Block any request so that the Blocking UI is enabled;
  3. Add at least 2 filters in the Request Blocking section;
  4. Hover over the X button for any filter;
  5. Click and hold the mouse button dragging the mouse over another one;
  6. Release the mouse button.

Expected result

  • x button for first filter is not displayed anymore;

Actual result

  • both x buttons are displayed;
  • first x button is displayed until another click is issued.

Regression range

  • not a regression, only visible after implementation of bug 1580728;

Additional notes

  • attached screenshot with the issue;
  • same issue if dragging from the filter/pattern text;
Has STR: --- → yes
Priority: -- → P3

I would like to take a shot at this issue if someone isn't working on this already.
Thank you
Kriyszig

(In reply to Kriyszig from comment #1)

I would like to take a shot at this issue if someone isn't working on this already.
Thank you
Kriyszig

The bug is now yours, thanks for helping!

Assignee: nobody → lelouch.cpp
Status: NEW → ASSIGNED

Click and drag on the closing button activates the :focus property
in CSS but doesn't trigger the onclick function. As a result, on a
click and drag event, the close button will remain in focus until
clicked on a vacant space or clicked on it again. When hovering over
other blockied URL, two close buttons appear instead on one (one in
focus, the other from the request on which mouse is hovering)
This commit removes the :focus from CSS. A click on the button will
delete the rule in real time. There is no scenario where the button
will need a focus on without removing the blocked URL from the list

@Kriyszig: thanks for working on this bug!

I filed a follow up bug 1625401 since the same problem is also in the Debugger panel.
You might be interested in fixing it there too.

Honza

Flags: needinfo?(lelouch.cpp)

I'll poke around the debugger part in the devtools and revert back on the Bug 1625401's discussion.
Thank you for filing the bug and bringing it to my attention @Honza.

Flags: needinfo?(lelouch.cpp)
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0617f3753446
Fix display of multiple close button on click and drag in network blocking panel r=Honza,bomsy
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76

Verified with 76.0a1 (2020-03-29).

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: