Closed Bug 1585307 Opened 5 years ago Closed 5 years ago

Netmonitor blocking - The same string is accepted twice in the Request Blocking list

Categories

(DevTools :: Netmonitor, defect, P2)

71 Branch
defect

Tracking

(firefox-esr60 disabled, firefox-esr68 disabled, firefox69 disabled, firefox70 disabled, firefox71 verified)

VERIFIED FIXED
Firefox 71
Tracking Status
firefox-esr60 --- disabled
firefox-esr68 --- disabled
firefox69 --- disabled
firefox70 --- disabled
firefox71 --- verified

People

(Reporter: csasca, Assigned: davidwalsh)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached image Double the trouble.gif

Affected versions

  • 71.0a1 (2019-10-1)

Affected platforms

  • All available

Steps to reproduce

  1. Launch Firefox;
  2. Set devtools.netmonitor.features.requestBlocking to true in about:config;
  3. Access any webpage, press F12 to open the DevTools inspector and select Network tab;
  4. Block any request so that the Blocking UI is enabled;
  5. Copy the blocked string and create a new entry on the Request Blocking list;

Expected result

  • The same string is not added to the list.

Actual result

  • The second entry for the same string is added.

Regression Range

  • Not a regression, only visible after implementation of bug 1580728;

Additional notes

  • Attached a recording with the issue;
  • If the method from STR doesn't work, then add another string to the list, and edit it with the first one (which is copied to clipboard).
Blocks: 1583111

I can't manage to create two blocking entries with the same string.
When trying to add an entry which is the same as an already existing, it isn't added after pressing the Enter key.

Is this still reproducible?
Any specific action I should do?

Honza

Flags: needinfo?(catalin.sasca)

Ok, try this: Block an url, and copy it's string too. After that, block a different entry, to add it to the blocked list. Next, edit the second blocked entry and paste the string that was saved to clipboard.

Flags: needinfo?(catalin.sasca)

(In reply to Catalin Sasca, QA [:csasca] from comment #2)

Ok, try this: Block an url, and copy it's string too. After that, block a different entry, to add it to the blocked list. Next, edit the second blocked entry and paste the string that was saved to clipboard.

I can reproduce that now, thanks!
Honza

Has STR: --- → yes
Priority: -- → P2
Assignee: nobody → dwalsh
Status: NEW → ASSIGNED
Attachment #9100334 - Attachment description: Bug 1585307 - Prevent URLs from beingn duplicated in Network Panel's request blocking r=honza → Bug 1585307 - Prevent URLs from being duplicated in Network Panel's request blocking r=honza
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ec5e79bb310
Prevent URLs from being duplicated in Network Panel's request blocking r=Honza
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

The issue is fixed in latest Firefox Nightly 71.0a1 (2019-10-13).

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: