Netmonitor blocking - "Search" and "Request Blocking" are draggable
Categories
(DevTools :: Netmonitor, defect, P3)
Tracking
(firefox-esr60 unaffected, firefox-esr68 unaffected, firefox67 unaffected, firefox68 unaffected, firefox69 unaffected, firefox70 unaffected, firefox71 verified)
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox-esr68 | --- | unaffected |
| firefox67 | --- | unaffected |
| firefox68 | --- | unaffected |
| firefox69 | --- | unaffected |
| firefox70 | --- | unaffected |
| firefox71 | --- | verified |
People
(Reporter: csasca, Assigned: davidwalsh)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(2 files)
Draggable buttons.gif
Affected versions
- 71.0a1 (2019-09-29)
Affected platforms
- All available
Steps to reproduce
- Launch Firefox;
- Set devtools.netmonitor.features.requestBlocking to true in about:config;
- Access any webpage, press F12 to open the DevTools inspector and select Network tab;
- Block any request so that the Blocking UI is enabled;
- Click and drag over "Search" or "Request Blocking";
Expected result
- "Search" and "request Blocking" are not draggable.
Actual result
- "Search" and "Request Blocking" are draggable.
Regression Range
- Not a regression, only visible after implementation of bug 1580728;
Additional notes
- Attached a recording with the issue;
- It seems that devtools expects the user to drag a .har file. If dragged to the tab bars, the drag is seen as a tab drag.
|
||
Comment 1•5 years ago
|
||
Thanks for the report!
I can't reproduce on Win10, is this MacOS only?
Honza
|
Reporter | |
Comment 2•5 years ago
|
||
Hi Jan, the screencast is from a Windows 10 system. Another thing that I saw is that they are draggable from the edges and not from the middle.
|
Assignee | |
Comment 4•5 years ago
|
||
Honza; Do you know why this is happening? Any background information here?
|
||
Comment 5•5 years ago
|
||
Bugbug thinks this bug is a regression, but please revert this change in case of error.
|
|
||
Comment 6•5 years ago
|
||
I think that it's because the tab is rendered using <a>
https://searchfox.org/mozilla-central/rev/5e830ac8f56fe191cb58a264e01cdbf6b6e847bd/devtools/client/shared/components/tabs/Tabs.js#316
Note that the Toolbox panel is using <button>
https://searchfox.org/mozilla-central/rev/5e830ac8f56fe191cb58a264e01cdbf6b6e847bd/devtools/client/framework/components/ToolboxTab.js#68
So, perhaps an option?
Honza
|
|
Assignee | |
Comment 7•5 years ago
|
||
|
||
Updated•5 years ago
|
Pushed by dwalsh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b059658718c9 Only allow files to be dropped onto HAR overlay r=Honza
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
|
||
Updated•5 years ago
|
|
||
Comment 10•5 years ago
|
||
Verified with 71.0b4 on the mentioned platforms.
Description
•