Affected versions

• 70.0b7, 71.0a1 (2019-09-05) ;

Affected platforms

• Windows 10, Ubuntu 18.40, macOS 10.12;

Steps to reproduce

1. Launch Firefox ;
2. Resize the browser to @ 1/4 width of the screen;
3. Click to open the address bar;

Expected result

• One-of search options are displayed in the screen;

Actual result

• The dropdown has a min-width that is fixed and does not take in account the resize;
• buttons get truncated instead of being shifted into a visible position(space is available for it);

Regression range

• Potential regressor: 1561894

Additional notes

• attached screenshot with the issue;

Adding Harry for a second opinion; in case this issue can be fixed with another existing bug.

(In reply to Cristian Fogel, QA [:cfogel] from comment #0)

Affected versions

• 70.0b7, 71.0a1 (2019-09-05) ;

This appears to be an old Nightly, please update.

Good point.
However, while with 71.0a1 (2019-09-16) the buttons are somewhat in order but the text before them is still fixed and taking up allot of the available space.

This is working as intended in comment 3's screenshot. I'm cc'ing Verdi just so he's aware of the UX here.

Verdi produced a spec for this that resizes with the page: https://firefox.michaelverdi.com/squish/. The minimum row width should match the length of the localized string.

I'm going to post a simple upliftable patch that I think addresses the main concern here and file a followup for verdi's more complex layout proposal.

Please remember to file the follow-up today, and make it block the megabar, we must meetup to discuss the path forward.

https://hg.mozilla.org/mozilla-central/rev/c6ceaf18bea3

Comment on attachment 9095544 [details]
Bug 1581753 - Improve one-off search button layout in narrow windows. r=mak

Beta/Release Uplift Approval Request

• User impact if declined: see comment 3
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: reduce the window width and type something in the address bar
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Pretty simple fix
• String changes made/needed:

With 71.0a1(2019-09-29) the main issue seems to be addressed.
However as per comment 6, one more improvement can be made for this case; the buttons being pushed bellow the "This time, search with:" text when bellow a certain width.

Should we file a separate bug/enhancement for it?

(In reply to Cristian Fogel, QA [:cfogel] from comment #13)

With 71.0a1(2019-09-29) the main issue seems to be addressed.
However as per comment 6, one more improvement can be made for this case; the buttons being pushed bellow the "This time, search with:" text when bellow a certain width.

Should we file a separate bug/enhancement for it?

We already filed bug 1584253 on this.

Awesome, thank you for the prompt reply!
Marking the issue verified for nightly.
Keeping the QE flag until we get the beta-fix approved & checked.

Comment on attachment 9095544 [details]
Bug 1581753 - Improve one-off search button layout in narrow windows. r=mak

CSS fix, verified in nightly, let's uplift for beta 12.

https://hg.mozilla.org/releases/mozilla-beta/rev/337981f64cc6

Fix verified with 70.0b12 as well.