Remove support for container scrolling
Categories
(Core :: Panning and Zooming, task, P3)
Tracking
()
People
(Reporter: botond, Assigned: botond)
References
Details
Attachments
(4 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
Bug 1577859 - Stop handling scrollbar layers that are descendants of the scrolled content. r=tnikkel
47 bytes,
text/x-phabricator-request
|
Details | Review |
Containerless scrolling has been shipping on Android since 67 (bug 1137890), and on desktop since long before that.
It's been pretty stable and we haven't seen any regressions from it in the past couple of release cycles.
I think this is a good time to remove the container scrolling code. This will make scrolling-related code easier to understand.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
There will be additional cleanup to remove codepaths that were only used with container scrolling but where the dependency is less obvious, but I'm posting what I have for now.
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D45198
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D45595
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 5•5 years ago
|
||
With containerless scrolling, scrollbar layers and their target scrolled layers
will be in sibling subtrees.
Depends on D45596
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/286cbc3b542b Remove the layout.scroll.root-frame-containers pref and code that depends directly on it. r=tnikkel
|
|
Assignee | |
Comment 7•5 years ago
|
||
I'm going to start landing this piece by piece.
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0ece55dd7147 Additional post container scrolling removal cleanup in Layout code. r=tnikkel
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
|
||
Comment 11•5 years ago
|
||
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e291531d8dbe Stop handling scrollbar layers that are descendants of the scrolled content. r=tnikkel https://hg.mozilla.org/integration/autoland/rev/c0797e496fd9 Additional post container scrolling removal cleanup in APZ code. r=tnikkel
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 12•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e291531d8dbe
https://hg.mozilla.org/mozilla-central/rev/c0797e496fd9
|
||
Updated•5 years ago
|
Description
•