Very low on-hover contrast in dark theme Change Search Settings button
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox-esr68 | --- | unaffected |
| firefox68 | --- | unaffected |
| firefox69 | --- | unaffected |
| firefox70 | --- | verified |
| firefox71 | --- | verified |
People
(Reporter: cfogel, Assigned: bugzilla)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
|
136.17 KB,
image/png
|
Details | |
|
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details | Review |
Screenshot from 2019-08-30 10-39-41.png
Affected versions
- 70.0b2, 70.0a1 (2019-08-29)
Affected platforms
- Ubuntu 16.04
Steps to reproduce
- Launch Firefox swap to Dark Theme and enable the search bar;
- Click inside the Search Bar and type any text;
- Hover over the Change Search Settings button;
Expected result
- Buttons are properly displayed;
Actual result
- the default state of the background_color for the button is the on_hover one;
- the hover effect makes it so the text is not readable;
Regression range
- Pushlog URL
- Potential regressor: bug 1561894;
Additional notes
- attached screenshot with the issue;
- 68, 69 builds are not affected;
|
||
Comment 1•5 years ago
|
||
I assume it was a mistake that your marked 69 as affected.
Harry, this is probably your regression. Can you take a look?
|
Reporter | |
Comment 2•5 years ago
|
||
Thank you for the correction, indeed was force of habit.
Re-confirmed with 69.0 and 69.b016 and they are not affected.
Managed to get the regression range as well, updating the initial post with the results.
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
While this problem is worst on Linux, I'm expanding the scope of this bug since contrast is low on all platforms. The attached patch affects all platforms as well.
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c166af1c637e Increase contrast on search settings button. r=dao
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
|
||
Comment 7•5 years ago
|
||
Can you request beta uplift? It would be nice to not ship this regression.
|
|
Assignee | |
Comment 8•5 years ago
|
||
Comment on attachment 9089946 [details]
Bug 1577708 - Increase contrast on search settings button. r?dao
Beta/Release Uplift Approval Request
- User impact if declined: Low contrast on a UI element. Contrast issues are bad enough that the element is sometimes invisible on Linux.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Single-line CSS change on a fairly low-traffic component of the browser (the standalone search bar).
- String changes made/needed:
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Comment 9•5 years ago
|
||
Comment on attachment 9089946 [details]
Bug 1577708 - Increase contrast on search settings button. r?dao
CSS fix, helps a11y, let's uplift.
|
||
Comment 10•5 years ago
|
||
| bugherder uplift | ||
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
||
Comment 11•5 years ago
|
||
I've managed to reproduce this issue on Firefox Nightly 70.0a1 (2019-08-29) and verified that it has been fixed on Nightly 71.0a1 (2019-9-10)
I'll be back to verify it on Beta 70b5 asap.
|
|
||
Comment 12•5 years ago
|
||
I've also verified the fix on Firefox Beta 70.0b5
Description
•