Closed Bug 1576639 Opened 5 years ago Closed 5 years ago

[object XULElement] string displayed instead of Custom Scale title

Categories

(Toolkit :: Printing, defect)

Product:
Toolkit
Component:
Printing
Platform:
Desktop
All
Type:
defect
Priority:
Not set
Severity:
normal
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla71
Iteration:
71.1 - Sept 2 - 15
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- wontfix
firefox68 --- wontfix
firefox69 --- wontfix
firefox70 --- verified
firefox71 --- verified

People

(Reporter: vlucaci, Assigned: dao)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Custom Scale String name.JPG
14.10 KB, image/jpeg
Details
Bug 1576639 - Fix Print Preview's Custom Scale prompt title. r=flod
47 bytes, text/x-phabricator-request
lizzard
: approval-mozilla-beta+
Details | Review

Affected versions

  • 69.0b16
  • 70.0a1 (2019-08-25)
  • 68.0.2

Affected platforms

  • Windows 10x64
  • macOS 10.14.6
  • Ubuntu 18.04x64

Steps to reproduce

  1. Launch FF.
  2. Go to http://www.africau.edu/images/default/sample.pdf.
  3. Go to the Burger menu and click on Print...
  4. In the header, click on Scale and Select Custom...

Expected result

  • The Scale prompt is shown and no string messages are displayed inside.

Actual result

  • The Custom Scale prompt is shown and the title of the prompt is a string message.

Regression range

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression
Flags: needinfo?(dao+bmo)
Regressed by: 1473265
Has Regression Range: --- → yes
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Component: Print Preview → Printing
Flags: needinfo?(dao+bmo)
Product: Core → Toolkit
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61482f0708f7
Fix Print Preview's Custom Scale prompt title. r=flod,fluent-reviewers

https://hg.mozilla.org/mozilla-central/rev/61482f0708f7

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Flags: qe-verify+

Comment on attachment 9090389 [details]
Bug 1576639 - Fix Print Preview's Custom Scale prompt title. r=flod

Beta/Release Uplift Approval Request

  • User impact if declined: please see comment 0
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: please see comment 0
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Pretty simple, straightforward fix
  • String changes made/needed:
Attachment #9090389 - Flags: approval-mozilla-beta?
QA Whiteboard: [qa-triaged]

Hello,

Confirming this issue as verified fixed on 71.0a1 (2019-09-05)(buildID:20190905215710). Checked on Windows 10x64 and Ubuntu 18.04x64.

Status: RESOLVED → VERIFIED
status-firefox71: fixed → verified

Comment on attachment 9090389 [details]
Bug 1576639 - Fix Print Preview's Custom Scale prompt title. r=flod

Simple fix, verified in nightly. OK for uplift for beta 5.

Attachment #9090389 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Hello,
Confirming this issue as verified fixed on 70.0b5(buildID:20190909162732). Checked on Windows 10x64 and Ubuntu 18.04x64.

status-firefox70: fixed → verified
Flags: qe-verify+
Iteration: --- → 71.1 - Sept 2 - 15
Points: --- → 2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: