• [Affected versions]:
  Firefox Beta 69.0b15

• [Affected Platforms]:
  All Windows
  All Mac
  All Linux

• [Prerequisites]:
  The "trailhead.firstrun.branches" pref was set to "join-supercharge".

• [Steps to reproduce]:

1. Install ar latest beta build
2. Open the browser and navigate to the "about:welcome" page
3. Observe the onboarding modal
4. Dismiss the onboarding modal and observe the supercharge cards

• [Expected result]:
  Elements on the onboarding and supercharge cards are displayed properly

• [Actual result]:
  'Brand-product name' is displayed in the about:welcome and on supercharge cards instead of the localizations for ar build

Please file this type of bugs in Mozilla Localizations::XXX, where XXX is the language (in this case Arabic).

@mardak
This works fine in Nightly. Are you aware of anything that would explain the issue in beta? The only thing I can spot is the double -- before the term.

The code, on the other hand, doesn't show that

<span>
  <h3 class="onboardingTitle" data-l10n-id="onboarding-data-sync-title">خُذ إعداداتك أينما ذهبت</h3>
  <p class="onboardingText" data-l10n-id="onboarding-data-sync-text2">زامِن علاماتك وكلمات السر وغيرها الكثير في أيّ مكان تستخدم فيه -brand-product-name.</p>
</span>

The error is present also in release (68.0.2 ‏(٦٤ بتة))

https://transvision.mozfr.org/string/?entity=browser/branding/official/brand.ftl:-brand-product-name&repo=gecko_strings doesn't list Arabic.

They don't have the -brand-product-name Term at all, all strings referring to that will get the runtime fallback output.

There's more locales affected than only Arabic as well, I think.

Argh, I didn't think about fallback for missing string.

This was migrated and removed, since it's transliterated. Nobody looked at it for 3 months :-
https://pontoon.mozilla.org/ar/firefox/browser/branding/official/brand.ftl/?search=-brand-product-name&string=197180
I just copied over the English text, I'll take a new sign off for Beta.

(In reply to Axel Hecht [:Pike] from comment #5)

They don't have the -brand-product-name Term at all, all strings referring to that will get the runtime fallback output.

Any clue why Nightly would work then (comment 3)?

There's more locales affected than only Arabic as well, I think.

I would expect those to not have the strings translated either. Would that fall back completely to English (entire sentence), or have the same problem?

Just to confirm…

resource:///localization/ar/branding/brand.ftl

nightly 70.0a1 Build ID 20190822095439

-brand-shorter-name = Nightly
-brand-short-name = Nightly
-brand-full-name = Firefox Nightly
# This brand name can be used in messages where the product name needs to
# remain unchanged across different versions (Nightly, Beta, etc.).
-brand-product-name = Firefox
-vendor-short-name = Mozilla
trademarkInfo = { " " }

beta 69.0b15 Build ID 20190819184224

-brand-short-name = فَيَرفُكس
-vendor-short-name = موزيلا
-brand-full-name = موزيلا فَيَرفُكس
-brand-shorter-name = فَيَرفُكس
trademarkInfo = فَيَرفُكس وشعاراته علامات تجارية لمؤسسة موزيلا.

Ah, that's because Nightly doesn't use the official branding, so everything falls back to en-US (and works).