Affected versions

• 68.0.2, 69.0b15, 70.a1(21-08-2019)

Affected platforms

• Ubuntu 18.04;

Steps to reproduce

1. Install any older Firefox build prior to 56.0a1 (2017-07-31), 57.0.4.

• example builds: nightly, RC

2. Launch Firefox, access any page(even in a new tab);
3. Perform an update (menu>About Firefox>Restart to Update browser) - browser is updated to a defined version;
4. Repeat step 3 - browser is updated to the latest version;
5. Attempt to access the pages/tabs from step 2.

Expected result

• pages are properly loaded;

Actual result

• pages are blank, the refresh button is disabled;

Regression range

• since trying to identify a regression range for this issue would be difficult and time consuming, would only attempt to find one if explicitly requested;

Additional notes

• on macOS the pages are loaded and not lost;
• on Windows OS the extra pages are not even opened after the update.

App update isn't involved with the code responsible for opening web pages and it doesn't touch anything in the profile where this information is stored. Moving to Session Restore since it has had bugs similar in the past.

Jonathan, IIRC you did some resilience work on principals, I suspect that's involved here, can you take a look?

I'm replicating this in 68.0 which means https://bugzilla.mozilla.org/show_bug.cgi?id=1508939 isn't the culprit here. I do however see drastically different principals in the session storage which is odd.

                    "entries": [
                        {
                            "url": "about:newtab",
                            "title": "New Tab",
                            "cacheKey": 0,
                            "ID": 3557904994,
                            "docshellUUID": "{3dc7186f-159e-4c96-9b2a-bf29f55d9416}",
                            "resultPrincipalURI": null,
                            "triggeringPrincipal_base64": "SmIS26zLEdO3ZQBgsLbOywAAAAAAAAAAwAAAAAAAAEY=",
                            "docIdentifier": 0,
                            "persist": true
                        },
                        {
                            "url": "https://www.google.com/search?q=sdsds&ie=utf-8&oe=utf-8&client=firefox-b-ab",
                            "title": "sdsds - Google Search",
                            "cacheKey": 0,
                            "ID": 3557904995,
                            "docshellUUID": "{3dc7186f-159e-4c96-9b2a-bf29f55d9416}",
                            "referrerInfo": "BBoSnxDOS9qmDeAnom1e0AAAAAAAAAAAwAAAAAAAAEYAAAAAAAEBAAAAAAEA",
                            "originalURI": "https://www.google.com/search?q=sdsds&ie=utf-8&oe=utf-8&client=firefox-b-ab",
                            "resultPrincipalURI": null,
                            "principalToInherit_base64": "vQZuXxRvRHKDMXv9BbHtkAAAAAAAAAAAwAAAAAAAAEYAAAA4bW96LW51bGxwcmluY2lwYWw6ezE4YjE3MmVkLTEyZTAtNGNhOC1hNjBkLTQ5MDEwOGQ2ZDY4Y30AAAAA",
                            "triggeringPrincipal_base64": "SmIS26zLEdO3ZQBgsLbOywAAAAAAAAAAwAAAAAAAAEY=",
                            "docIdentifier": 1,
                            "persist": true
                        },
                        {
                            "url": "https://www.google.com/search?client=firefox-b-ab&ei=5GFlXab5ONPrgAbd2ZnQAQ&q=kjhjkhjh324099099090&oq=kjhjkhjh324099099090&gs_l=psy-ab.3...2356.3614..3908...0.2..0.90.1082.19......0....1..gws-wiz.......0i71j0j0i131j0i10.Vx0dOfbOf6k&ved=0ahUKEwim-_3Hw6PkAhXTNcAKHd1sBhoQ4dUDCAo&uact=5",
                            "title": "kjhjkhjh324099099090 - Google Search",
                            "cacheKey": 0,
                            "ID": 3557904996,
                            "docshellUUID": "{3dc7186f-159e-4c96-9b2a-bf29f55d9416}",
                            "referrerInfo": "BBoSnxDOS9qmDeAnom1e0AAAAAAAAAAAwAAAAAAAAEYBAAAAS2h0dHBzOi8vd3d3Lmdvb2dsZS5jb20vc2VhcmNoP3E9c2RzZHMmaWU9dXRmLTgmb2U9dXRmLTgmY2xpZW50PWZpcmVmb3gtYi1hYgAAAAMBAQAAABdodHRwczovL3d3dy5nb29nbGUuY29tLwEA",
                            "originalURI": "https://www.google.com/search?client=firefox-b-ab&ei=5GFlXab5ONPrgAbd2ZnQAQ&q=kjhjkhjh324099099090&oq=kjhjkhjh324099099090&gs_l=psy-ab.3...2356.3614..3908...0.2..0.90.1082.19......0....1..gws-wiz.......0i71j0j0i131j0i10.Vx0dOfbOf6k&ved=0ahUKEwim-_3Hw6PkAhXTNcAKHd1sBhoQ4dUDCAo&uact=5",
                            "resultPrincipalURI": null,
                            "principalToInherit_base64": "ZT4OTT7kRfqycpfCC8AeuAAAAAAAAAAAwAAAAAAAAEYB3pRy0IA0EdOTmQAQS6D9QJIHOlRteE8wkTq4cYEyCMYAAAAC/////wAAAbsBAAAAS2h0dHBzOi8vd3d3Lmdvb2dsZS5jb20vc2VhcmNoP3E9c2RzZHMmaWU9dXRmLTgmb2U9dXRmLTgmY2xpZW50PWZpcmVmb3gtYi1hYgAAAAAAAAAFAAAACAAAAA4AAAAI/////wAAAAj/////AAAACAAAAA4AAAAWAAAANQAAABYAAAAHAAAAFgAAAAEAAAAXAAAABgAAABf/////AAAAAP////8AAAAeAAAALQAAABb/////AQAAAAAAAAAAAAAAAQnZ7Rrl1EAEv+Anzrkj2ayzxMCuvV5MrYfgjSENuz+fAd6UctCANBHTk5kAEEug/UCSBzpUbXhPMJE6uHGBMgjGAAAAAv////8AAAG7AQAAAEtodHRwczovL3d3dy5nb29nbGUuY29tL3NlYXJjaD9xPXNkc2RzJmllPXV0Zi04Jm9lPXV0Zi04JmNsaWVudD1maXJlZm94LWItYWIAAAAAAAAABQAAAAgAAAAOAAAACP////8AAAAI/////wAAAAgAAAAOAAAAFgAAADUAAAAWAAAABwAAABYAAAABAAAAFwAAAAYAAAAX/////wAAAAD/////AAAAHgAAAC0AAAAW/////wEAAAAAAAAAAAAA",
                            "triggeringPrincipal_base64": "ZT4OTT7kRfqycpfCC8AeuAAAAAAAAAAAwAAAAAAAAEYB3pRy0IA0EdOTmQAQS6D9QJIHOlRteE8wkTq4cYEyCMYAAAAC/////wAAAbsBAAAAS2h0dHBzOi8vd3d3Lmdvb2dsZS5jb20vc2VhcmNoP3E9c2RzZHMmaWU9dXRmLTgmb2U9dXRmLTgmY2xpZW50PWZpcmVmb3gtYi1hYgAAAAAAAAAFAAAACAAAAA4AAAAI/////wAAAAj/////AAAACAAAAA4AAAAWAAAANQAAABYAAAAHAAAAFgAAAAEAAAAXAAAABgAAABf/////AAAAAP////8AAAAeAAAALQAAABb/////AQAAAAAAAAAAAAAAAQnZ7Rrl1EAEv+Anzrkj2ayzxMCuvV5MrYfgjSENuz+fAd6UctCANBHTk5kAEEug/UCSBzpUbXhPMJE6uHGBMgjGAAAAAv////8AAAG7AQAAAEtodHRwczovL3d3dy5nb29nbGUuY29tL3NlYXJjaD9xPXNkc2RzJmllPXV0Zi04Jm9lPXV0Zi04JmNsaWVudD1maXJlZm94LWItYWIAAAAAAAAABQAAAAgAAAAOAAAACP////8AAAAI/////wAAAAgAAAAOAAAAFgAAADUAAAAWAAAABwAAABYAAAABAAAAFwAAAAYAAAAX/////wAAAAD/////AAAAHgAAAC0AAAAW/////wEAAAAAAAAAAAAA",
                            "csp": "CdntGuXUQAS/4CfOuSPZrAAAAAAAAAAAwAAAAAAAAEYB3pRy0IA0EdOTmQAQS6D9QJIHOlRteE8wkTq4cYEyCMYAAAAC/////wAAAbsBAAAAS2h0dHBzOi8vd3d3Lmdvb2dsZS5jb20vc2VhcmNoP3E9c2RzZHMmaWU9dXRmLTgmb2U9dXRmLTgmY2xpZW50PWZpcmVmb3gtYi1hYgAAAAAAAAAFAAAACAAAAA4AAAAI/////wAAAAj/////AAAACAAAAA4AAAAWAAAANQAAABYAAAAHAAAAFgAAAAEAAAAXAAAABgAAABf/////AAAAAP////8AAAAeAAAALQAAABb/////AQAAAAAAAAAAAAA=",
                            "docIdentifier": 2,
                            "persist": true
                        }
                    ],

Still looking into it currently...

I see the issue when updating after 57.0.4... after updating with this session store file it then doesn't load the old tabs.

This is the session file post 57.0.4.

I don't see anything notable different in the sessionstore file the only errors that seem remotely connected in the session storage that I can see are:

Attempt to set a remote URL https://www.google.com/favicon.ico as a tab icon without a loading principal. tabbrowser.js:827:15
Attempt to set a remote URL https://www.google.com/favicon.ico as a tab icon without a loading principal. tabbrowser.js:827:15
Attempt to set a remote URL https://www.google.com/favicon.ico as a tab icon without a loading principal. tabbrowser.js:827:15
Attempt to set a remote URL https://www.google.com/favicon.ico as a tab icon without a loading principal. tabbrowser.js:827:15

Mike is there anything you can see here that you could see would cause this? These entries don't have principals which means they should fallback to null principal as I understand it.

So the errors you quoted in comment 6 are not things that would make sessionstore stop working. The fallback for favicons would indeed be the null principal, so I can't tell you anything helpful, I'm afraid.