Remove loadstart and loadend event from <img>
Categories
(Core :: DOM: Core & HTML, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox108 | --- | fixed |
People
(Reporter: annevk, Assigned: smaug)
References
Details
(Keywords: site-compat)
Attachments
(1 file)
See https://github.com/whatwg/html/pull/4842. As bz remarks in bug 1501554 comment 5, this feature got added to the specification without much of a plan. It seems that Firefox somehow picked up part of it.
Simple test at https://github.com/web-platform-tests/wpt/pull/18499.
Bug 1264769 suggests we added loadend too, but I cannot reproduce.
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
There's at least some code for loadend events, so it should probably be removed too even if it doesn't work.
|
||
Comment 2•4 years ago
|
||
Is this bug as simple as it looks? E.g., similar to bug 1548773?
If so, can I take it? :-)
|
Reporter | |
Comment 3•4 years ago
|
||
Famous last words, but I would expect this to be fairly straightforward given the PR against HTML. And you don't even need to write new tests.
|
|
||
Comment 4•4 years ago
•
|
||
The fact that we have the same event name for FileReader API and media elements makes this a bit tricky.
The events seem to be used in Firefox Desktop code and tests as well. So, it's not exactly trivial :/
I'll file some blocking bugs.
Here's quick list (there may be more).
loadend
https://searchfox.org/mozilla-central/rev/fac90408bcf52ca88a3dcd2ef30a379b68ab24e2/browser/base/content/pageinfo/pageInfo.js#895
loadend in Tests:
https://searchfox.org/mozilla-central/rev/fac90408bcf52ca88a3dcd2ef30a379b68ab24e2/browser/base/content/test/pageinfo/browser_pageinfo_image_info.js
https://searchfox.org/mozilla-central/rev/fac90408bcf52ca88a3dcd2ef30a379b68ab24e2/browser/components/shell/test/test_headless_screenshot.html#93
https://searchfox.org/mozilla-central/rev/fac90408bcf52ca88a3dcd2ef30a379b68ab24e2/browser/base/content/test/pageinfo/browser_pageinfo_firstPartyIsolation.js
loadstart in tests
https://searchfox.org/mozilla-central/rev/fac90408bcf52ca88a3dcd2ef30a379b68ab24e2/browser/base/content/test/pageinfo/browser_pageinfo_firstPartyIsolation.js#29
|
||
Comment 5•3 years ago
|
||
I filed bug 1718651 about the onloadend event handler attribute, mentioning it here too so that this bug can be found when searching for it.
|
||
Updated•2 years ago
|
|
Assignee | |
Comment 7•2 years ago
|
||
Depends on D159930
|
||
Updated•2 years ago
|
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ccd076f67748 Remove loadstart and loadend event from <img>, r=edgar
|
||
Comment 9•2 years ago
|
||
Backed out for causing mochitest failures on browser_staticPartition_saveAs.js
|
|
Assignee | |
Comment 10•2 years ago
|
||
boo, I must have missed one case where the event is used.
|
||
Comment 11•2 years ago
|
||
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/24e535a8836b Remove loadstart and loadend event from <img>, r=edgar
|
||
Comment 12•2 years ago
|
||
| bugherder | ||
Description
•